From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tomasz Figa <tomasz.figa@gmail.com>
Subject: Re: [PATCH v3 18/32] drm/exynos: Implement mode_fixup manager
	operation
Date: Sun, 10 Nov 2013 22:33:56 +0100
Message-ID: <1920450.rgVvHarAfV@flatron>
References: <1383063198-10526-1-git-send-email-seanpaul@chromium.org>
	<1383063198-10526-19-git-send-email-seanpaul@chromium.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Received: from mail-ee0-f46.google.com (mail-ee0-f46.google.com [74.125.83.46])
	by gabe.freedesktop.org (Postfix) with ESMTP id C9264FA605
	for <dri-devel@lists.freedesktop.org>;
	Sun, 10 Nov 2013 22:16:17 -0800 (PST)
Received: by mail-ee0-f46.google.com with SMTP id b57so2195963eek.33
	for <dri-devel@lists.freedesktop.org>;
	Sun, 10 Nov 2013 22:16:16 -0800 (PST)
In-Reply-To: <1383063198-10526-19-git-send-email-seanpaul@chromium.org>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Sender: dri-devel-bounces@lists.freedesktop.org
Errors-To: dri-devel-bounces@lists.freedesktop.org
To: Sean Paul <seanpaul@chromium.org>
Cc: dri-devel@lists.freedesktop.org, marcheu@chromium.org
List-Id: dri-devel@lists.freedesktop.org

On Tuesday 29 of October 2013 12:13:04 Sean Paul wrote:
> This patch adds a new manager callback for mode_fixup and pipes it
> through exynos_drm_crtc.

Patch description lacking explanation what this change is for.

> 
> Signed-off-by: Sean Paul <seanpaul@chromium.org>
> ---
> 
> Changes in v2: None
> Changes in v3: None
> 
>  drivers/gpu/drm/exynos/exynos_drm_crtc.c | 7 ++++++-
>  drivers/gpu/drm/exynos/exynos_drm_drv.h  | 4 ++++
>  2 files changed, 10 insertions(+), 1 deletion(-)

Otherwise the code looks fine.

Best regards,
Tomasz