Re: [PATCH i-g-t v2 3/8] tools/vbt_decode: return 0 from get_device_id()

[Jani Nikula <jani.nikula@intel.com>]

On Mon, 08 Jun 2026, Michał Grzelak <michal.grzelak@intel.com> wrote:
> This function returns -1 on errors and the caller checks for 0. This
> leads to -1 being used as the device id. Return 0 instead of -1.
>
> Signed-off-by: Michał Grzelak <michal.grzelak@intel.com>

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

> ---
>  tools/intel_vbt_decode.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/intel_vbt_decode.c b/tools/intel_vbt_decode.c
> index 5b7a6a49e9..6a9c1de7b3 100644
> --- a/tools/intel_vbt_decode.c
> +++ b/tools/intel_vbt_decode.c
> @@ -3700,13 +3700,13 @@ get_device_id(unsigned char *bios, int size)
>      int offset = (bios[0x19] << 8) + bios[0x18];
>  
>      if (offset + 7 >= size)
> -	return -1;
> +	return 0;
>  
>      if (bios[offset] != 'P' ||
>  	bios[offset+1] != 'C' ||
>  	bios[offset+2] != 'I' ||
>  	bios[offset+3] != 'R')
> -	return -1;
> +	return 0;
>  
>      device = (bios[offset+7] << 8) + bios[offset+6];

-- 
Jani Nikula, Intel