All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Helin Zhang <helin.zhang@intel.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH] i40e: fix the issue of cannot using more than 1 poor for VMDq
Date: Wed, 11 Nov 2015 11:13:55 +0100	[thread overview]
Message-ID: <1922858.TuGxmDPMa1@xps13> (raw)
In-Reply-To: <1447232205-2339-1-git-send-email-helin.zhang@intel.com>

Comments on the git message:

After the word "fix" in the title, the word "issue" is useless.
It's better to have a short title, easy to parse in the commit list.

What is a poor? Do you mean pool?

2015-11-11 16:56, Helin Zhang:
> It fixes the issue of cannot using more than 1 poor for VMDq,
> according to the queues left.

You forgot to describe the bug.
What happens when we use more than 1?

> Fixes: 705b57f82054 ("i40e: enlarge the number of supported queues")

Thanks for providing the Fixes line.

> Signed-off-by: Helin Zhang <helin.zhang@intel.com>

  reply	other threads:[~2015-11-11 10:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-11  8:56 [PATCH] i40e: fix the issue of cannot using more than 1 poor for VMDq Helin Zhang
2015-11-11 10:13 ` Thomas Monjalon [this message]
2015-11-11 18:37 ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1922858.TuGxmDPMa1@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=dev@dpdk.org \
    --cc=helin.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.