From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: From: Laurent Pinchart To: Geert Uytterhoeven Cc: Laurent Pinchart , Linux Media Mailing List , Linux-Renesas , Kieran Bingham , devicetree@vger.kernel.org Subject: Re: [PATCH v4 2/4] dt-bindings: Add Renesas R-Car FDP1 bindings Date: Mon, 24 Oct 2016 12:46:46 +0300 Message-ID: <1923730.zaykC4sXJR@avalon> In-Reply-To: References: <1477299818-31935-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com> <1477299818-31935-3-git-send-email-laurent.pinchart+renesas@ideasonboard.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" List-ID: Hi Geert, On Monday 24 Oct 2016 11:14:11 Geert Uytterhoeven wrote: > On Mon, Oct 24, 2016 at 11:03 AM, Laurent Pinchart wrote: > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/media/renesas,fdp1.txt > > @@ -0,0 +1,33 @@ > > +Renesas R-Car Fine Display Processor (FDP1) > > +------------------------------------------- > > + > > +The FDP1 is a de-interlacing module which converts interlaced video to > > +progressive video. It is capable of performing pixel format conversion > > between +YCbCr/YUV formats and RGB formats. Only YCbCr/YUV formats are > > supported as +an input to the module. > > + > > + - compatible: Must be the following > > + > > + - "renesas,fdp1" for generic compatible > > + > > + - reg: the register base and size for the device registers > > + - interrupts : interrupt specifier for the FDP1 instance > > + - clocks: reference to the functional clock > > + - renesas,fcp: reference to the FCPF connected to the FDP1 > > + > > +Optional properties: > > + - power-domains : power-domain property defined with a power domain > > specifier > "power domain"? > > > + to respective power domain. > > Still, too many power domains in one sentence? How about - power-domains : reference to the power domain that the FDP1 belongs to, if any. -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v4 2/4] dt-bindings: Add Renesas R-Car FDP1 bindings Date: Mon, 24 Oct 2016 12:46:46 +0300 Message-ID: <1923730.zaykC4sXJR@avalon> References: <1477299818-31935-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com> <1477299818-31935-3-git-send-email-laurent.pinchart+renesas@ideasonboard.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Geert Uytterhoeven Cc: Laurent Pinchart , Linux Media Mailing List , Linux-Renesas , Kieran Bingham , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org Hi Geert, On Monday 24 Oct 2016 11:14:11 Geert Uytterhoeven wrote: > On Mon, Oct 24, 2016 at 11:03 AM, Laurent Pinchart wrote: > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/media/renesas,fdp1.txt > > @@ -0,0 +1,33 @@ > > +Renesas R-Car Fine Display Processor (FDP1) > > +------------------------------------------- > > + > > +The FDP1 is a de-interlacing module which converts interlaced video to > > +progressive video. It is capable of performing pixel format conversion > > between +YCbCr/YUV formats and RGB formats. Only YCbCr/YUV formats are > > supported as +an input to the module. > > + > > + - compatible: Must be the following > > + > > + - "renesas,fdp1" for generic compatible > > + > > + - reg: the register base and size for the device registers > > + - interrupts : interrupt specifier for the FDP1 instance > > + - clocks: reference to the functional clock > > + - renesas,fcp: reference to the FCPF connected to the FDP1 > > + > > +Optional properties: > > + - power-domains : power-domain property defined with a power domain > > specifier > "power domain"? > > > + to respective power domain. > > Still, too many power domains in one sentence? How about - power-domains : reference to the power domain that the FDP1 belongs to, if any. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html