From: Thomas Monjalon <thomas@monjalon.net>
To: Ophir Munk <ophirmu@nvidia.com>
Cc: Ori Kam <orika@nvidia.com>, "dev@dpdk.org" <dev@dpdk.org>,
Raslan Darawsheh <rasland@nvidia.com>,
stable@dpdk.org,
Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v1] app/regex: fix segfault in getopt_long call
Date: Tue, 20 Oct 2020 00:06:39 +0200 [thread overview]
Message-ID: <1925730.gUPrjPanqK@thomas> (raw)
In-Reply-To: <ae33c2bc-3d69-0d66-2a92-ea7a766926d5@partner.samsung.com>
> >> getopt_long() parses command-line arguments. One of its arguments
> >> 'longopts' is a pointer to the first element of an array of struct
> >> option. The last element of the array has to be filled with zeros
> >> to mark the end of options. For example:
> >>
> >> struct option longopts[] = {
> >> { "help", 0, 0, ARG_HELP},
> >> ....
> >> /* End of options */
> >> { 0, 0, 0, 0 }
> >> };
> >>
> >> This commit adds the last element. Prior to this commit getopt_long()
> >> continued parsing beyond the longopts[] array which occasionally caused
> >> segmentation faults.
> >>
> >> Fixes: de06137cb295 ("app/regex: add RegEx test application")
> >> Cc: stable@dpdk.org
> >>
> >> Signed-off-by: Ophir Munk <ophirmu@nvidia.com>
> > Acked-by: Ori Kam <orika@nvidia.com>
> Acked-by: Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>
Applied, thanks
prev parent reply other threads:[~2020-10-19 22:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-18 14:21 [dpdk-dev] [PATCH v1] app/regex: fix segfault in getopt_long call Ophir Munk
2020-10-19 7:46 ` Ori Kam
2020-10-19 8:13 ` Lukasz Wojciechowski
2020-10-19 8:39 ` Ophir Munk
2020-10-19 22:05 ` Thomas Monjalon
2020-10-19 22:06 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1925730.gUPrjPanqK@thomas \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=l.wojciechow@partner.samsung.com \
--cc=ophirmu@nvidia.com \
--cc=orika@nvidia.com \
--cc=rasland@nvidia.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.