From: Thomas Monjalon <thomas@monjalon.net>
To: Georgios Katsikas <katsikas.gp@gmail.com>
Cc: Wisam Monther <wisamm@nvidia.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] app/flow-perf: configurable rule batches
Date: Tue, 06 Oct 2020 00:25:41 +0200 [thread overview]
Message-ID: <1926489.DYHX6cUqRX@thomas> (raw)
In-Reply-To: <CAN9HtFAoP5_U7PNTkjEQTFEseTYF6nk-OnKdyhgo=p2JswMS2w@mail.gmail.com>
05/10/2020 19:16, Georgios Katsikas:
> Hi,
>
> What is the conclusion?
> I haven't seen this patch being committed yet.
You missed updating the file doc/guides/tools/flow-perf.rst
> On Thu, Sep 24, 2020 at 3:01 PM Wisam Monther <wisamm@nvidia.com> wrote:
> >From: Georgios Katsikas
> > >
> > >* One can now configure the number of rules per batch
Please develop a bit more what was the previous behaviour
and what you mean by "batch" in this context.
> > >* Refactored flow_count variable to rules_count as it is related to the
> > newly
> > >added rules_batch variable
> > >* Added default values to usage function
> > >
> > >Signed-off-by: Georgios Katsikas <katsikas.gp@gmail.com>
> >
> > Acked-by: Wisam Jaddo <wisamm@nvidia.com>
Wisam, you should not ack if the doc is not updated.
Otherwise you will have to complete the doc update yourself ;)
next prev parent reply other threads:[~2020-10-05 22:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-24 9:10 [dpdk-dev] [PATCH] app/flow-perf: configurable rule batches Georgios Katsikas
2020-09-24 12:01 ` Wisam Monther
2020-10-05 17:16 ` Georgios Katsikas
2020-10-05 22:25 ` Thomas Monjalon [this message]
2020-10-11 10:33 ` Georgios Katsikas
-- strict thread matches above, loose matches on Subject: below --
2020-10-11 10:03 Georgios Katsikas
2020-11-03 11:26 ` Georgios Katsikas
2020-11-04 8:04 ` Wisam Monther
2020-11-04 11:11 ` Georgios Katsikas
2020-11-04 11:25 ` Wisam Monther
2020-11-04 20:46 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1926489.DYHX6cUqRX@thomas \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=katsikas.gp@gmail.com \
--cc=wisamm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.