From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [RFC][PATCH 1/3] drm/bridge: adv7511: Rework adv7511_power_on/off() so they can be reused internally Date: Tue, 22 Nov 2016 10:27:42 +0200 Message-ID: <1926540.Y3AOuWnbYN@avalon> References: <1479775052-28194-1-git-send-email-john.stultz@linaro.org> <1961666.AZMl081OYz@avalon> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from galahad.ideasonboard.com (galahad.ideasonboard.com [185.26.127.97]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2AA316E1EA for ; Tue, 22 Nov 2016 08:27:26 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: John Stultz Cc: lkml , "dri-devel@lists.freedesktop.org" , Wolfram Sang List-Id: dri-devel@lists.freedesktop.org SGkgSm9obiwKCk9uIFR1ZXNkYXkgMjIgTm92IDIwMTYgMDA6MTY6NTUgSm9obiBTdHVsdHogd3Jv dGU6Cj4gT24gVHVlLCBOb3YgMjIsIDIwMTYgYXQgMTI6MTQgQU0sIExhdXJlbnQgUGluY2hhcnQg d3JvdGU6Cj4gPiBPbiBNb25kYXkgMjEgTm92IDIwMTYgMTY6Mzc6MzAgSm9obiBTdHVsdHogd3Jv dGU6Cj4gPj4gSW4gY2hhc2luZyBkb3duIGlzc3VlcyB3aXRoIEVESUQgcHJvYmluZywgSSBmb3Vu ZCBzb21lCj4gPj4gZHVwbGljYXRlZCBidXQgaW5jb21wbGV0ZSBsb2dpYyB1c2VkIHRvIHBvd2Vy IHRoZSBjaGlwIG9uIGFuZAo+ID4+IG9mZi4KPiA+PiAKPiA+PiBUaGlzIHBhdGNoIHJlZmFjdG9y cyB0aGUgYWR2NzUxMV9wb3dlcl9vbi9vZmYgZnVuY3Rpb25zLCBzbwo+ID4+IHRoZXkgY2FuIGJl IHVzZWQgZm9yIGludGVybmFsIG5lZWRzLCBhbmQgcmVwbGFjZXMgZHVwbGljYXRpdmUKPiA+PiBs b2dpYyB0aGF0IHBvd2VycyB0aGUgY2hpcCBvbiBhbmQgb2ZmIGFyb3VuZCB0aGUgRURJRCBwcm9i aW5nCj4gPj4gd2l0aCB0aGUgY29tbW9uIGxvZ2ljLgo+ID4+IAo+ID4+IENjOiBEYXZpZCBBaXJs aWUgPGFpcmxpZWRAbGludXguaWU+Cj4gPj4gQ2M6IEFyY2hpdCBUYW5lamEgPGFyY2hpdHRAY29k ZWF1cm9yYS5vcmc+Cj4gPj4gQ2M6IFdvbGZyYW0gU2FuZyA8d3NhK3JlbmVzYXNAc2FuZy1lbmdp bmVlcmluZy5jb20+Cj4gPj4gQ2M6IExhcnMtUGV0ZXIgQ2xhdXNlbiA8bGFyc0BtZXRhZm9vLmRl Pgo+ID4+IENjOiBMYXVyZW50IFBpbmNoYXJ0IDxsYXVyZW50LnBpbmNoYXJ0QGlkZWFzb25ib2Fy ZC5jb20+Cj4gPj4gQ2M6IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiA+PiBTaWdu ZWQtb2ZmLWJ5OiBKb2huIFN0dWx0eiA8am9obi5zdHVsdHpAbGluYXJvLm9yZz4KPiA+PiAtLS0K PiA+PiAKPiA+PiAgZHJpdmVycy9ncHUvZHJtL2JyaWRnZS9hZHY3NTExL2Fkdjc1MTFfZHJ2LmMg fCAzMCArKysrKysrKystLS0tLS0tLS0tLS0tCj4gPj4gIDEgZmlsZSBjaGFuZ2VkLCAxNCBpbnNl cnRpb25zKCspLCAxNiBkZWxldGlvbnMoLSkKPiA+PiAKPiA+PiBkaWZmIC0tZ2l0IGEvZHJpdmVy cy9ncHUvZHJtL2JyaWRnZS9hZHY3NTExL2Fkdjc1MTFfZHJ2LmMKPiA+PiBiL2RyaXZlcnMvZ3B1 L2RybS9icmlkZ2UvYWR2NzUxMS9hZHY3NTExX2Rydi5jIGluZGV4IDhkYmE3MjkuLmIyNDBlMDUK PiA+PiAxMDA2NDQKPiA+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vYnJpZGdlL2Fkdjc1MTEvYWR2 NzUxMV9kcnYuYwo+ID4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9icmlkZ2UvYWR2NzUxMS9hZHY3 NTExX2Rydi5jCj4gPj4gQEAgLTMyNSw3ICszMjUsNyBAQCBzdGF0aWMgdm9pZCBhZHY3NTExX3Nl dF9saW5rX2NvbmZpZyhzdHJ1Y3QgYWR2NzUxMQo+ID4+ICphZHY3NTExLCBhZHY3NTExLT5yZ2Ig PSBjb25maWctPmlucHV0X2NvbG9yc3BhY2UgPT0gSERNSV9DT0xPUlNQQUNFX1JHQjsKPiA+PiAK PiA+PiAgfQo+ID4+IAo+ID4+IC1zdGF0aWMgdm9pZCBhZHY3NTExX3Bvd2VyX29uKHN0cnVjdCBh ZHY3NTExICphZHY3NTExKQo+ID4+ICtzdGF0aWMgdm9pZCBfX2Fkdjc1MTFfcG93ZXJfb24oc3Ry dWN0IGFkdjc1MTEgKmFkdjc1MTEpCj4gPj4gIHsKPiA+PiAgICAgICBhZHY3NTExLT5jdXJyZW50 X2VkaWRfc2VnbWVudCA9IC0xOwo+ID4+IAo+ID4+IEBAIC0zNDMsNiArMzQzLDcgQEAgc3RhdGlj IHZvaWQgYWR2NzUxMV9wb3dlcl9vbihzdHJ1Y3QgYWR2NzUxMSAqYWR2NzUxMSkKPiA+PiAgICAg ICAgICAgICAgICAgICAgICAgICAgICBBRFY3NTExX0lOVDFfRERDX0VSUk9SKTsKPiA+PiAgICAg ICB9Cj4gPj4gCj4gPj4gKwo+ID4gCj4gPiBUaGlzIGlzbid0IG5lZWRlZC4KPiAKPiBBcG9sb2dp ZXMuIEkgc2F3IHRoaXMgcmlnaHQgYWZ0ZXIgSSBzZW50IGl0IQo+IAo+ID4+ICAgICAgIC8qCj4g Pj4gICAgICAgICogUGVyIHNwZWMgaXQgaXMgYWxsb3dlZCB0byBwdWxzZSB0aGUgSFBEIHNpZ25h bCB0byBpbmRpY2F0ZSB0aGF0Cj4gPj4gICAgICAgIHRoZQo+ID4+ICAgICAgICAqIEVESUQgaW5m b3JtYXRpb24gaGFzIGNoYW5nZWQuIFNvbWUgbW9uaXRvcnMgZG8gdGhpcyB3aGVuIHRoZXkKPiA+ PiB3YWtldXAKPiA+PiBAQCAtMzYyLDExICszNjMsMTUgQEAgc3RhdGljIHZvaWQgYWR2NzUxMV9w b3dlcl9vbihzdHJ1Y3QgYWR2NzUxMQo+ID4+ICphZHY3NTExKQo+ID4+IAo+ID4+ICAgICAgIGlm IChhZHY3NTExLT50eXBlID09IEFEVjc1MzMpCj4gPj4gICAgICAgICAgICAgICBhZHY3NTMzX2Rz aV9wb3dlcl9vbihhZHY3NTExKTsKPiA+PiArfQo+ID4+IAo+ID4+ICtzdGF0aWMgdm9pZCBhZHY3 NTExX3Bvd2VyX29uKHN0cnVjdCBhZHY3NTExICphZHY3NTExKQo+ID4+ICt7Cj4gPj4gKyAgICAg X19hZHY3NTExX3Bvd2VyX29uKGFkdjc1MTEpOwo+ID4+ICAgICAgIGFkdjc1MTEtPnBvd2VyZWQg PSB0cnVlOwo+ID4+ICB9Cj4gPj4gCj4gPj4gLXN0YXRpYyB2b2lkIGFkdjc1MTFfcG93ZXJfb2Zm KHN0cnVjdCBhZHY3NTExICphZHY3NTExKQo+ID4+ICtzdGF0aWMgdm9pZCBfX2Fkdjc1MTFfcG93 ZXJfb2ZmKHN0cnVjdCBhZHY3NTExICphZHY3NTExKQo+ID4+ICB7Cj4gPj4gICAgICAgLyogVE9E Tzogc2V0dXAgYWRkaXRpb25hbCBwb3dlciBkb3duIG1vZGVzICovCj4gPj4gICAgICAgcmVnbWFw X3VwZGF0ZV9iaXRzKGFkdjc1MTEtPnJlZ21hcCwgQURWNzUxMV9SRUdfUE9XRVIsCj4gPj4gQEAg LTM3Niw3ICszODEsMTEgQEAgc3RhdGljIHZvaWQgYWR2NzUxMV9wb3dlcl9vZmYoc3RydWN0IGFk djc1MTEKPiA+PiAqYWR2NzUxMSkKPiA+PiAKPiA+PiAgICAgICBpZiAoYWR2NzUxMS0+dHlwZSA9 PSBBRFY3NTMzKQo+ID4+ICAgICAgICAgICAgICAgYWR2NzUzM19kc2lfcG93ZXJfb2ZmKGFkdjc1 MTEpOwo+ID4+ICt9Cj4gPj4gCj4gPj4gK3N0YXRpYyB2b2lkIGFkdjc1MTFfcG93ZXJfb2ZmKHN0 cnVjdCBhZHY3NTExICphZHY3NTExKQo+ID4+ICt7Cj4gPj4gKyAgICAgX19hZHY3NTExX3Bvd2Vy X29mZihhZHY3NTExKTsKPiA+PiAgICAgICBhZHY3NTExLT5wb3dlcmVkID0gZmFsc2U7Cj4gPj4g IH0KPiA+PiAKPiA+PiBAQCAtNTQ1LDI0ICs1NTQsMTMgQEAgc3RhdGljIGludCBhZHY3NTExX2dl dF9tb2RlcyhzdHJ1Y3QgYWR2NzUxMQo+ID4+ICphZHY3NTExLAo+ID4+ICAgICAgIHVuc2lnbmVk IGludCBjb3VudDsKPiA+PiAgICAgICAKPiA+PiAgICAgICAvKiBSZWFkaW5nIHRoZSBFRElEIG9u bHkgd29ya3MgaWYgdGhlIGRldmljZSBpcyBwb3dlcmVkICovCj4gPj4gLSAgICAgaWYgKCFhZHY3 NTExLT5wb3dlcmVkKSB7Cj4gPj4gLSAgICAgICAgICAgICByZWdtYXBfdXBkYXRlX2JpdHMoYWR2 NzUxMS0+cmVnbWFwLCBBRFY3NTExX1JFR19QT1dFUiwKPiA+PiAtICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBBRFY3NTExX1BPV0VSX1BPV0VSX0RPV04sIDApOwo+ID4+IC0gICAgICAg ICAgICAgaWYgKGFkdjc1MTEtPmkyY19tYWluLT5pcnEpIHsKPiA+PiAtICAgICAgICAgICAgICAg ICAgICAgcmVnbWFwX3dyaXRlKGFkdjc1MTEtPnJlZ21hcCwKPiA+IAo+ID4gQURWNzUxMV9SRUdf SU5UX0VOQUJMRSgwKSwKPiA+IAo+ID4+IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgQURWNzUxMV9JTlQwX0VESURfUkVBRFkpOwo+ID4+IC0gICAgICAgICAgICAgICAgICAgICBy ZWdtYXBfd3JpdGUoYWR2NzUxMS0+cmVnbWFwLAo+ID4+IEFEVjc1MTFfUkVHX0lOVF9FTkFCTEUo MSksCj4gPj4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBBRFY3NTExX0lOVDFf RERDX0VSUk9SKTsKPiA+PiAtICAgICAgICAgICAgIH0KPiA+PiAtICAgICAgICAgICAgIGFkdjc1 MTEtPmN1cnJlbnRfZWRpZF9zZWdtZW50ID0gLTE7Cj4gPj4gLSAgICAgfQo+ID4+ICsgICAgIGlm ICghYWR2NzUxMS0+cG93ZXJlZCkKPiA+PiArICAgICAgICAgICAgIF9fYWR2NzUxMV9wb3dlcl9v bihhZHY3NTExKTsKPiA+IAo+ID4gVGhlIF9fYWR2NzUxMV9wb3dlcl9vbigpIGZ1bmN0aW9uIGRv ZXMgbW9yZSB0aGFuIHRoZSBhYm92ZSwgaW4gcGFydGljdWxhcgo+ID4gaXQgcGVyZm9ybXMgYW4g ZXhwZW5zaXZlIHJlZ2NhY2hlX3N5bmMoKSBhbmQgY2FsbHMgYWR2NzUzM19kc2lfcG93ZXJfb24o KQo+ID4gZm9yIHRoZSBBRFY3NTMzLiBEb24ndCB0aG9zZSBvcGVyYXRpb25zIGhhdmUgc2lkZSBl ZmZlY3RzIHRoYXQgYXJlIGVpdGhlcgo+ID4gbm90IHdhbnRlZCBvciBub3QgbmVlZGVkIGhlcmUg PyBJbiBhbnkgY2FzZSB0aGlzIHBhdGNoIG1vZGlmaWVzIHRoZQo+ID4gYmVoYXZpb3VyIG9mIHRo ZSBkcml2ZXIsIHdoaWNoIG5lZWRzIHRvIGJlIGRvY3VtZW50ZWQgaW4gdGhlIGtlcm5lbAo+ID4g bWVzc2FnZS4KPiAKPiBTb3JyeSwgd2hhdCBkbyB5b3UgbWVhbiBieSBrZXJuZWwgbWVzc2FnZT8g Q29tbWl0IG1lc3NhZ2UsIG1heWJlPwoKU29ycnksIHllcywgSSBtZWFudCBjb21taXQgbWVzc2Fn ZS4KCj4gRmFpciBwb2ludCwgSSdsbCByZXZpZXcgdGhlIGFkdjc1MzNfZHNpX3Bvd2VyX29uIGJp dHMgYW5kIHNlZSBpZiB0aGV5Cj4gc2hvdWxkIG1vdmUgb3V0IHRvIHRoZSBleHRlcm5hbCBmdW5j dGlvbiByYXRoZXIgdGhlbiB0aGUgaW50ZXJuYWwgb25lLgo+IFNpbWlsYXJseSBmb3IgdGhlIHJl Z2NhY2hlX3N5bmMuCj4gCj4gVGhhbmtzIHNvIG11Y2ggZm9yIHRoZSByZXZpZXchCgotLSAKUmVn YXJkcywKCkxhdXJlbnQgUGluY2hhcnQKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZy ZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755570AbcKVI11 (ORCPT ); Tue, 22 Nov 2016 03:27:27 -0500 Received: from galahad.ideasonboard.com ([185.26.127.97]:33642 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755472AbcKVI10 (ORCPT ); Tue, 22 Nov 2016 03:27:26 -0500 From: Laurent Pinchart To: John Stultz Cc: lkml , David Airlie , Archit Taneja , Wolfram Sang , Lars-Peter Clausen , "dri-devel@lists.freedesktop.org" Subject: Re: [RFC][PATCH 1/3] drm/bridge: adv7511: Rework adv7511_power_on/off() so they can be reused internally Date: Tue, 22 Nov 2016 10:27:42 +0200 Message-ID: <1926540.Y3AOuWnbYN@avalon> User-Agent: KMail/4.14.10 (Linux/4.8.6-gentoo; KDE/4.14.24; x86_64; ; ) In-Reply-To: References: <1479775052-28194-1-git-send-email-john.stultz@linaro.org> <1961666.AZMl081OYz@avalon> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi John, On Tuesday 22 Nov 2016 00:16:55 John Stultz wrote: > On Tue, Nov 22, 2016 at 12:14 AM, Laurent Pinchart wrote: > > On Monday 21 Nov 2016 16:37:30 John Stultz wrote: > >> In chasing down issues with EDID probing, I found some > >> duplicated but incomplete logic used to power the chip on and > >> off. > >> > >> This patch refactors the adv7511_power_on/off functions, so > >> they can be used for internal needs, and replaces duplicative > >> logic that powers the chip on and off around the EDID probing > >> with the common logic. > >> > >> Cc: David Airlie > >> Cc: Archit Taneja > >> Cc: Wolfram Sang > >> Cc: Lars-Peter Clausen > >> Cc: Laurent Pinchart > >> Cc: dri-devel@lists.freedesktop.org > >> Signed-off-by: John Stultz > >> --- > >> > >> drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 30 +++++++++------------- > >> 1 file changed, 14 insertions(+), 16 deletions(-) > >> > >> diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c > >> b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c index 8dba729..b240e05 > >> 100644 > >> --- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c > >> +++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c > >> @@ -325,7 +325,7 @@ static void adv7511_set_link_config(struct adv7511 > >> *adv7511, adv7511->rgb = config->input_colorspace == HDMI_COLORSPACE_RGB; > >> > >> } > >> > >> -static void adv7511_power_on(struct adv7511 *adv7511) > >> +static void __adv7511_power_on(struct adv7511 *adv7511) > >> { > >> adv7511->current_edid_segment = -1; > >> > >> @@ -343,6 +343,7 @@ static void adv7511_power_on(struct adv7511 *adv7511) > >> ADV7511_INT1_DDC_ERROR); > >> } > >> > >> + > > > > This isn't needed. > > Apologies. I saw this right after I sent it! > > >> /* > >> * Per spec it is allowed to pulse the HPD signal to indicate that > >> the > >> * EDID information has changed. Some monitors do this when they > >> wakeup > >> @@ -362,11 +363,15 @@ static void adv7511_power_on(struct adv7511 > >> *adv7511) > >> > >> if (adv7511->type == ADV7533) > >> adv7533_dsi_power_on(adv7511); > >> +} > >> > >> +static void adv7511_power_on(struct adv7511 *adv7511) > >> +{ > >> + __adv7511_power_on(adv7511); > >> adv7511->powered = true; > >> } > >> > >> -static void adv7511_power_off(struct adv7511 *adv7511) > >> +static void __adv7511_power_off(struct adv7511 *adv7511) > >> { > >> /* TODO: setup additional power down modes */ > >> regmap_update_bits(adv7511->regmap, ADV7511_REG_POWER, > >> @@ -376,7 +381,11 @@ static void adv7511_power_off(struct adv7511 > >> *adv7511) > >> > >> if (adv7511->type == ADV7533) > >> adv7533_dsi_power_off(adv7511); > >> +} > >> > >> +static void adv7511_power_off(struct adv7511 *adv7511) > >> +{ > >> + __adv7511_power_off(adv7511); > >> adv7511->powered = false; > >> } > >> > >> @@ -545,24 +554,13 @@ static int adv7511_get_modes(struct adv7511 > >> *adv7511, > >> unsigned int count; > >> > >> /* Reading the EDID only works if the device is powered */ > >> - if (!adv7511->powered) { > >> - regmap_update_bits(adv7511->regmap, ADV7511_REG_POWER, > >> - ADV7511_POWER_POWER_DOWN, 0); > >> - if (adv7511->i2c_main->irq) { > >> - regmap_write(adv7511->regmap, > > > > ADV7511_REG_INT_ENABLE(0), > > > >> - ADV7511_INT0_EDID_READY); > >> - regmap_write(adv7511->regmap, > >> ADV7511_REG_INT_ENABLE(1), > >> - ADV7511_INT1_DDC_ERROR); > >> - } > >> - adv7511->current_edid_segment = -1; > >> - } > >> + if (!adv7511->powered) > >> + __adv7511_power_on(adv7511); > > > > The __adv7511_power_on() function does more than the above, in particular > > it performs an expensive regcache_sync() and calls adv7533_dsi_power_on() > > for the ADV7533. Don't those operations have side effects that are either > > not wanted or not needed here ? In any case this patch modifies the > > behaviour of the driver, which needs to be documented in the kernel > > message. > > Sorry, what do you mean by kernel message? Commit message, maybe? Sorry, yes, I meant commit message. > Fair point, I'll review the adv7533_dsi_power_on bits and see if they > should move out to the external function rather then the internal one. > Similarly for the regcache_sync. > > Thanks so much for the review! -- Regards, Laurent Pinchart