All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Thomas Schmitt" <scdbackup@gmx.net>
To: grub-devel@gnu.org
Cc: lidong.chen@oracle.com,development@efficientek.com,dkiper@net-space.pl
Subject: Re: [PATCH 0/2] fs/iso9660: Delay CE hop until end of current SUSP area
Date: Thu, 30 Mar 2023 23:10:31 +0200	[thread overview]
Message-ID: <19266276877819224021@scdbackup.webframe.org> (raw)
In-Reply-To: <20230330183010.ndmhyzb7ebeokhzm@tomti.i.net-space.pl>

Hi,


Daniel Kiper wrote:
> AIUI this [1] email presented some concerns.
> [1] https://lists.gnu.org/archive/html/grub-devel/2023-03/msg00022.html

This was about the trailing blank in the output of grub-fstest.

I decided to simply remove it because it is not expectable that any wrong
handling of a CE entry would produce blanks from the two filename
alternatives "ROCKRIDG.;1" and "RockRidgeName:x".
So i wrote in [PATCH 2/2]:

  +# Before comparing: remove trailing blank added by grub-fstest
  +output=$(echo -n $output)

(I remember to have found the origin of the blank somewhere in the deeper
levels of the code, possibly grub-core/commands/ls.c function print_files.
It did not look like it would be reasonable to ask for changing it.)


Have a nice day :)

Thomas



  reply	other threads:[~2023-03-30 21:10 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-07 16:56 [PATCH 0/2] fs/iso9660: Delay CE hop until end of current SUSP area Thomas Schmitt
2023-03-07 16:56 ` [PATCH 1/2] " Thomas Schmitt
2023-03-07 16:56 ` [PATCH 2/2] tests: Add test for iso9660 delayed CE hop Thomas Schmitt
2023-03-09  6:28 ` [PATCH 0/2] fs/iso9660: Delay CE hop until end of current SUSP area Lidong Chen
2023-03-31 17:25   ` Lidong Chen
2023-03-30 18:30 ` Daniel Kiper
2023-03-30 21:10   ` Thomas Schmitt [this message]
2023-03-31  0:57   ` Glenn Washburn
2023-03-31 16:47     ` Daniel Kiper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=19266276877819224021@scdbackup.webframe.org \
    --to=scdbackup@gmx.net \
    --cc=development@efficientek.com \
    --cc=dkiper@net-space.pl \
    --cc=grub-devel@gnu.org \
    --cc=lidong.chen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.