From: Bob Peterson <rpeterso@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [gfs2-utils PATCH] fsck.gfs2: time each of the passes
Date: Thu, 10 Jul 2014 12:53:01 -0400 (EDT) [thread overview]
Message-ID: <1927182008.6308945.1405011181430.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <187372922.6308414.1405011111441.JavaMail.zimbra@redhat.com>
Hi,
This patch reports how much time was taken in each pass.
Regards,
Bob Peterson
Red Hat File Systems
Signed-off-by: Bob Peterson <rpeterso@redhat.com>
---
gfs2/fsck/main.c | 19 ++++++++++++++++++-
1 file changed, 18 insertions(+), 1 deletion(-)
diff --git a/gfs2/fsck/main.c b/gfs2/fsck/main.c
index 81b7dd5..785f0c4 100644
--- a/gfs2/fsck/main.c
+++ b/gfs2/fsck/main.c
@@ -11,6 +11,7 @@
#include <signal.h>
#include <libintl.h>
#include <locale.h>
+#include <sys/time.h>
#define _(String) gettext(String)
#include <syslog.h>
@@ -247,11 +248,14 @@ static const struct fsck_pass passes[] = {
static int fsck_pass(const struct fsck_pass *p, struct gfs2_sbd *sdp)
{
int ret;
+ long hh, mm, ss, ms;
+ struct timeval before, after;
if (fsck_abort)
return FSCK_CANCELED;
pass = p->name;
log_notice( _("Starting %s\n"), p->name);
+ gettimeofday(&before, 0);
ret = p->f(sdp);
if (ret)
exit(ret);
@@ -260,7 +264,20 @@ static int fsck_pass(const struct fsck_pass *p, struct gfs2_sbd *sdp)
log_notice( _("%s interrupted \n"), p->name);
return FSCK_CANCELED;
}
- log_notice( _("%s complete \n"), p->name);
+ gettimeofday(&after, 0);
+ hh = (after.tv_sec - before.tv_sec) / 3600;
+ mm = ((after.tv_sec - before.tv_sec) / 60) - (hh * 60);
+ ss = ((after.tv_sec - before.tv_sec)) - (hh * 3600) - (mm * 60);
+ ms = after.tv_usec - before.tv_usec;
+ if (ms < 0)
+ ms += 1000000;
+ ms /= 1000;
+ log_notice( _("%s completed in "), p->name);
+ if (hh)
+ log_notice("%ldh", hh);
+ if (mm)
+ log_notice("%ldm", mm);
+ log_notice("%ld.%03lds \n", ss, ms);
return 0;
}
next parent reply other threads:[~2014-07-10 16:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <187372922.6308414.1405011111441.JavaMail.zimbra@redhat.com>
2014-07-10 16:53 ` Bob Peterson [this message]
2014-07-11 16:05 ` [Cluster-devel] [gfs2-utils PATCH] fsck.gfs2: time each of the passes Steven Whitehouse
2014-07-11 17:41 ` Bob Peterson
2014-07-11 17:58 ` Steven Whitehouse
2014-07-11 19:44 ` Bob Peterson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1927182008.6308945.1405011181430.JavaMail.zimbra@redhat.com \
--to=rpeterso@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.