From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
Cc: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>, dev@dpdk.org
Subject: Re: [PATCH] lib/librte_ether: bypass code cleanup
Date: Mon, 11 Jul 2016 11:19:22 +0200 [thread overview]
Message-ID: <1927507.Pj5eqIlGbv@xps13> (raw)
In-Reply-To: <2601191342CEEE43887BDE71AB97725836B7C73C@irsmsx105.ger.corp.intel.com>
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon
> > Hmmm. It's true it is cleaner. But I am not sure having a generic API
> > for bypass is a good idea at all.
> > I was thinking to totally remove it.
>
> Why to remove it?
> As I know there are people who use that functionality.
>
> > Maybe we can try to have a specific API by including ixgbe_bypass.h in
> > the application.
>
> Hmm, isn't that what we were trying to get rid of in last few years?
> HW specific stuff?
Yes exactly.
I have the feeling the bypass API is specific to ixgbe. Isn't it?
As we will probably see other features specific to only one device.
Instead of adding a function in the generic API, I think it may be
saner to include a driver header. Then if it appears to be used
in more devices, it can be generalized.
What do you think of this approach?
next prev parent reply other threads:[~2016-07-11 9:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-11 6:21 [PATCH] lib/librte_ether: bypass code cleanup Wenzhuo Lu
2016-07-11 7:11 ` Thomas Monjalon
2016-07-11 8:09 ` Lu, Wenzhuo
2016-07-11 8:18 ` Ananyev, Konstantin
2016-07-11 9:19 ` Thomas Monjalon [this message]
2016-07-11 9:56 ` Ananyev, Konstantin
2016-07-11 10:19 ` specific driver API - was " Thomas Monjalon
2016-07-11 10:39 ` Ananyev, Konstantin
2016-07-11 7:50 ` [PATCH] lib/librte_ether: " Wu, Jingjing
2016-07-11 8:09 ` Lu, Wenzhuo
2016-07-11 8:29 ` [PATCH v2] app/testpmd: " Wenzhuo Lu
2016-07-11 13:18 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1927507.Pj5eqIlGbv@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.