From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Jackson Subject: Re: build fixes Date: Tue, 12 Jan 2010 17:22:01 +0000 Message-ID: <19276.44985.149108.19729@mariner.uk.xensource.com> References: <201001111258.26274.Christoph.Egger@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <201001111258.26274.Christoph.Egger@amd.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Christoph Egger Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org Christoph Egger writes ("[Xen-devel] build fixes"): > Attached patch fixes Xen build on NetBSD. Nack. > +#include /* for pid_t */ This is fine but should read: #include as there is no point putting /* for somethingorother */ after every #include. > - if (!isdigit(p[i])) { > + if (!isdigit((uint8_t)p[i])) { This is correct on all platforms. But it should be fixed by some more general approach, as it's needed for almost every call to a ctype macro. > - seek_ret = lseek64(fd, i << PAGE_SHIFT, SEEK_SET); > + seek_ret = lseek(fd, i << PAGE_SHIFT, SEEK_SET); This is just wrong. It will break on >2G files. Ian.