From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5A6072EF2A7; Wed, 23 Jul 2025 15:29:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753284597; cv=pass; b=FbtSuvOSw9NtMS/I0tSh8+xhxNkIEtxBGY51B5bPbqNT1udVNS5baEaMOO/bd8ykrIKOu4N/xjgmhOH2ux1s6ETi7M1WsuSOROGi9Dik9+4kR6oIdzcp5wZHnqhkFalEJSUzGIYaZtmt/t+YP/jR+RReR7dFRb+SSGZZfA86Ldo= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753284597; c=relaxed/simple; bh=Uc7VdifhLPjOrJXBESlgXL5i2ILIKqQAfCzoqTjF9bE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=sM513jO5YKiA04/JaIKG4fnWlcbKNhd20LqdbrbtjVN7jGekytAYVbgEnt2x1ucdrMP7Pk2oYbKZ3A+KEk0niLql22Ss0pSWYwxL8CFT8WQ083/kGW0tmpMPcysNSOmCtFGaKLB2ufrHSpMct5AcP5Q/JNHutZrKSikRir9v8/8= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=detlev.casanova@collabora.com header.b=Qu6aQ8jd; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=detlev.casanova@collabora.com header.b="Qu6aQ8jd" ARC-Seal: i=1; a=rsa-sha256; t=1753284551; cv=none; d=zohomail.com; s=zohoarc; b=XRtulgxgQtjCSgT8DD64R1R0tydqvcpKjitZFNrZaE7SiTelJybBZ8+mq47N7MsBpzeLQvEJAVMU4+PPSW8HdbkN8Sd4TaXMAisblYbxndPRGvhMW3o5PzcpkLW0M8zJNqxNCQPM/+GFgu2tFSNLJbLazenHRQNgodNPcANEdX4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1753284551; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=p1mGR8RrETsRU+pbOh6xvnBmADrKnol8mLncWhNqDJQ=; b=jKBUZyW67QgODDAqPhyEbkag/COEC4vUmGJcJ9vQny4fea7GdZ3colZc2jyS9VLh/xuznbeu4IDXsknEWRuIiikepXMBjMXI4BldpF1cg0BxLOD5Z0OuJkuDR2sWAhrATBMhalwo0EA5wT/L3sZlZmO128bdHdb3EcaprYTVyvs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=detlev.casanova@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1753284551; s=zohomail; d=collabora.com; i=detlev.casanova@collabora.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Content-Type:Message-Id:Reply-To; bh=p1mGR8RrETsRU+pbOh6xvnBmADrKnol8mLncWhNqDJQ=; b=Qu6aQ8jdjF8N8nxtXSZMDjdtk5wkI6HZkXVap3gYJWE99ERRUx7eyXgm1a7Ugp8v 56KOyX1KqBr9BR+46aQQ+2rSEpIwIeZFDNRqErIkW2FGqM3HnVxXqX+6Tlj9RU41Ahp NpHkxMKiddIAhGknPdVcQ+2MWBZYaJI8OkKOUVw0= Received: by mx.zohomail.com with SMTPS id 1753284550006678.199939611792; Wed, 23 Jul 2025 08:29:10 -0700 (PDT) From: Detlev Casanova To: Mark Brown Cc: linux-kernel@vger.kernel.org, Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Dmitry Baryshkov , Douglas Anderson , Heiko Stuebner , Sugar Zhang , Cristian Ciocaltea , Charles Keepax , Raag Jadav , dri-devel@lists.freedesktop.org, linux-sound@vger.kernel.org, kernel@collabora.com Subject: Re: [PATCH v2 2/3] ASoC: hdac_hdmi: Use dev_info on invalid ELD version Date: Wed, 23 Jul 2025 11:29:07 -0400 Message-ID: <1927750.tdWV9SEqCh@earth> In-Reply-To: References: <20250722195437.1347865-1-detlev.casanova@collabora.com> <20250722195437.1347865-3-detlev.casanova@collabora.com> Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" X-ZohoMailClient: External Hi Mark, On Wednesday, 23 July 2025 06:40:13 EDT Mark Brown wrote: > On Tue, Jul 22, 2025 at 03:54:36PM -0400, Detlev Casanova wrote: > > When disconnected, the ELD data cannot be read by the display driver, so > > it just sets the data to 0. > > Please don't put patches for different subsystems into the same series > if there's no dependencies, it just makes dependencies less obvious and > creates hassle merging things. Yes, sorry, I'll send v3 of this patch separately. > > That makes the ELD parsing code read an ELD version of 0, which is > > invalid. In hdac_hdmi, that is logged with dev_err(), but should be > > logged with dev_info() instead as it is done in sound/core/pcm_drm_eld.c > > > > This avoids printing multiple messages like: > > HDMI: Unknown ELD version 0 > > > > in the kernel log when userspace tries to open the sound device. > > It doesn't, it just lowers the severity of the logs that are printed. > If the goal is to lower the number of messages printed you need to use > a ratelimited print. I see, ratelimited would be good, but it still prints a message about something that is normal behaviour. Maybe this should go further to a dev_dbg(), or is there a specific reason to show this message ? This could also be a special case: - version == 0 -> dev_dbg() - version !=0 && != known_versions -> dev_err() Detlev.