From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] eal:Change log output to DEBUG instead of INFO Date: Fri, 12 Feb 2016 18:56:49 +0100 Message-ID: <1928276.P2Lqin6BEp@xps13> References: <1441914050-43168-1-git-send-email-keith.wiles@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: sergio.gonzalez.monroy@intel.com, anatoly.burakov@intel.com, david.marchand@6wind.com Return-path: Received: from mail-wm0-f45.google.com (mail-wm0-f45.google.com [74.125.82.45]) by dpdk.org (Postfix) with ESMTP id 5F43C2A5B for ; Fri, 12 Feb 2016 18:58:20 +0100 (CET) Received: by mail-wm0-f45.google.com with SMTP id c200so31749917wme.0 for ; Fri, 12 Feb 2016 09:58:20 -0800 (PST) In-Reply-To: <1441914050-43168-1-git-send-email-keith.wiles@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Sergio, Anatoly, David, It is not so obvious to decide the log level. Please comment or ack. 2015-09-10 14:40, Keith Wiles: > When log level is set to 7 (INFO) these messages are still displayed > and should be set to DEBUG. > > Signed-off-by: Keith Wiles > --- > lib/librte_eal/common/eal_common_memory.c | 2 +- > lib/librte_eal/common/eal_common_timer.c | 2 +- > lib/librte_eal/linuxapp/eal/eal_pci_vfio.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/lib/librte_eal/common/eal_common_memory.c b/lib/librte_eal/common/eal_common_memory.c > index b647573..6155752 100644 > --- a/lib/librte_eal/common/eal_common_memory.c > +++ b/lib/librte_eal/common/eal_common_memory.c > @@ -139,7 +139,7 @@ rte_eal_memdevice_init(void) > int > rte_eal_memory_init(void) > { > - RTE_LOG(INFO, EAL, "Setting up physically contiguous memory...\n"); > + RTE_LOG(DEBUG, EAL, "Setting up physically contiguous memory...\n"); > > const int retval = rte_eal_process_type() == RTE_PROC_PRIMARY ? > rte_eal_hugepage_init() : > diff --git a/lib/librte_eal/common/eal_common_timer.c b/lib/librte_eal/common/eal_common_timer.c > index 72371b8..c4227cd 100644 > --- a/lib/librte_eal/common/eal_common_timer.c > +++ b/lib/librte_eal/common/eal_common_timer.c > @@ -81,6 +81,6 @@ set_tsc_freq(void) > if (!freq) > freq = estimate_tsc_freq(); > > - RTE_LOG(INFO, EAL, "TSC frequency is ~%" PRIu64 " KHz\n", freq / 1000); > + RTE_LOG(DEBUG, EAL, "TSC frequency is ~%" PRIu64 " KHz\n", freq / 1000); > eal_tsc_resolution_hz = freq; > } > diff --git a/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c b/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c > index 0e6c48a..e0c13de 100644 > --- a/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c > +++ b/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c > @@ -904,7 +904,7 @@ pci_vfio_enable(void) > > /* return 0 if VFIO modules not loaded */ > if (module_vfio_type1 == 0) { > - RTE_LOG(INFO, EAL, "VFIO modules not all loaded, " > + RTE_LOG(DEBUG, EAL, "VFIO modules not all loaded, " > "skip VFIO support...\n"); > return 0; > } >