Re: [dpdk-dev] [PATCH v2] ip_frag: promote APIs to stable

[Thomas Monjalon <thomas@monjalon.net>]

28/10/2021 13:51, Konstantin Ananyev:
> Promote rte_frag_table_del_expired_entries() function to stable.
> It was around for few years by now without any changes.
> 
> Signed-off-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> ---
>  lib/ip_frag/rte_ip_frag.h | 1 -

In general, the namespace in this file is wrong.
A lot of structs and enum don't have the correct name prefix.


> --- a/lib/ip_frag/version.map
> +++ b/lib/ip_frag/version.map
> @@ -1,6 +1,7 @@
>  DPDK_22 {
>  	global:
>  
> +	rte_frag_table_del_expired_entries;

It seems that the right name should be rte_ip_frag_table_del_expired_entries.

>  	rte_ip_frag_free_death_row;
>  	rte_ip_frag_table_create;
>  	rte_ip_frag_table_destroy;
> @@ -12,9 +13,3 @@ DPDK_22 {
>  
>  	local: *;
>  };
> -
> -EXPERIMENTAL {
> -	global:
> -
> -	rte_frag_table_del_expired_entries;
> -};

We could keep this name as experimental during an expiration period.