From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko =?ISO-8859-1?Q?St=FCbner?= Subject: Re: [PATCH 10/12] arm64: dts: rockchip: Add PX30 CRTCs graph LVDS endpoints Date: Fri, 13 Dec 2019 19:28:21 +0100 Message-ID: <1933192.L6hp5CucIl@diego> References: <20191213181051.25983-1-miquel.raynal@bootlin.com> <20191213181051.25983-11-miquel.raynal@bootlin.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20191213181051.25983-11-miquel.raynal@bootlin.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Miquel Raynal Cc: Mark Rutland , devicetree@vger.kernel.org, Thomas Petazzoni , David Airlie , Sandy Huang , dri-devel@lists.freedesktop.org, Maxime Chevallier , Paul Kocialkowski , linux-rockchip@lists.infradead.org, Rob Herring , linux-arm-kernel@lists.infradead.org List-Id: linux-rockchip.vger.kernel.org Hi Miquel, Am Freitag, 13. Dezember 2019, 19:10:49 CET schrieb Miquel Raynal: > Add the display subsystem routes with the two available CRTCs: vopb > and vopl (big and little). For each CRTC, add the LVDS endpoints. MIPI > DSI endpoints will come later. > > Signed-off-by: Miquel Raynal > --- > arch/arm64/boot/dts/rockchip/px30.dtsi | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/arch/arm64/boot/dts/rockchip/px30.dtsi b/arch/arm64/boot/dts/rockchip/px30.dtsi > index b2af0f02ecbe..1c96ba556daf 100644 > --- a/arch/arm64/boot/dts/rockchip/px30.dtsi > +++ b/arch/arm64/boot/dts/rockchip/px30.dtsi > @@ -190,6 +190,16 @@ > compatible = "rockchip,display-subsystem"; > ports = <&vopb_out>, <&vopl_out>; > status = "disabled"; > + > + route { > + route_vopb_lvds: route-vopb-lvds { > + connect = <&vopb_out_lvds>; > + }; > + > + route_vopl_lvds: route-vopl-lvds { > + connect = <&vopl_out_lvds>; > + }; > + }; where does this route-stuff come from? The vendor tree? Because so far I've not seen this in mainline-drm in general nor the Rockchip drm driver itself. > }; > > gmac_clkin: external-gmac-clock { > @@ -976,6 +986,11 @@ > vopb_out: port { > #address-cells = <1>; > #size-cells = <0>; > + > + vopb_out_lvds: endpoint@0 { > + reg = <0>; > + remote-endpoint = <&lvds_vopb_in>; > + }; This (and the one below) would create dangling phandle references and compile errors, because the referenced phandles only get introduced in patch12. So ideally merge this into the last patch. Heiko > }; > }; > > @@ -1008,6 +1023,11 @@ > vopl_out: port { > #address-cells = <1>; > #size-cells = <0>; > + > + vopl_out_lvds: endpoint@0 { > + reg = <0>; > + remote-endpoint = <&lvds_vopl_in>; > + }; > }; > }; > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC9C2C00454 for ; Fri, 13 Dec 2019 22:22:59 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B3FFF20706 for ; Fri, 13 Dec 2019 22:22:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="CSmHfKXs" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B3FFF20706 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=H3EAL3MXztWrdVr6zM4FmU3efCGkh52X2qS0BJHyMHY=; b=CSmHfKXs3jHsNM h6XBPEd3Mx5Sp/kZNfASV6QbvYmqzot1Y1fNIomaGJBOazQn1hzsxnmUMolJLHe9cHLrRfyvzI/Wh NDesfR7S78GIyetOJYy3u1AIDl5dCju/Ranxum8g3QTCdgNYNMbLA13miSJRI7MnGFWNVzNcKvy2X +9rhTX4UUYlj+AIjCwSlRsB5m/2nvP9W93WeeD97FdUGOfaiF5GMnSJMvdEyKClaERhPf8rYfMb8c Vd9XmGvneNTL9favhVbEiF0E0WN7Qzbns1rACaF0BUdbCNkdamq1oh3BOuW1BtghVdW6ueJouXq0I 3YTdGsMwBJtIVDWVkC3A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ifphB-0001sK-R7; Fri, 13 Dec 2019 18:29:45 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ifpg1-0000o7-RL; Fri, 13 Dec 2019 18:28:39 +0000 Received: from ip5f5a6266.dynamic.kabel-deutschland.de ([95.90.98.102] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1ifpfq-0003GI-A5; Fri, 13 Dec 2019 19:28:22 +0100 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Miquel Raynal Subject: Re: [PATCH 10/12] arm64: dts: rockchip: Add PX30 CRTCs graph LVDS endpoints Date: Fri, 13 Dec 2019 19:28:21 +0100 Message-ID: <1933192.L6hp5CucIl@diego> In-Reply-To: <20191213181051.25983-11-miquel.raynal@bootlin.com> References: <20191213181051.25983-1-miquel.raynal@bootlin.com> <20191213181051.25983-11-miquel.raynal@bootlin.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191213_102834_058603_C14CD11E X-CRM114-Status: GOOD ( 14.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Thomas Petazzoni , David Airlie , Sandy Huang , dri-devel@lists.freedesktop.org, Maxime Chevallier , Paul Kocialkowski , linux-rockchip@lists.infradead.org, Rob Herring , Daniel Vetter , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Miquel, Am Freitag, 13. Dezember 2019, 19:10:49 CET schrieb Miquel Raynal: > Add the display subsystem routes with the two available CRTCs: vopb > and vopl (big and little). For each CRTC, add the LVDS endpoints. MIPI > DSI endpoints will come later. > > Signed-off-by: Miquel Raynal > --- > arch/arm64/boot/dts/rockchip/px30.dtsi | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/arch/arm64/boot/dts/rockchip/px30.dtsi b/arch/arm64/boot/dts/rockchip/px30.dtsi > index b2af0f02ecbe..1c96ba556daf 100644 > --- a/arch/arm64/boot/dts/rockchip/px30.dtsi > +++ b/arch/arm64/boot/dts/rockchip/px30.dtsi > @@ -190,6 +190,16 @@ > compatible = "rockchip,display-subsystem"; > ports = <&vopb_out>, <&vopl_out>; > status = "disabled"; > + > + route { > + route_vopb_lvds: route-vopb-lvds { > + connect = <&vopb_out_lvds>; > + }; > + > + route_vopl_lvds: route-vopl-lvds { > + connect = <&vopl_out_lvds>; > + }; > + }; where does this route-stuff come from? The vendor tree? Because so far I've not seen this in mainline-drm in general nor the Rockchip drm driver itself. > }; > > gmac_clkin: external-gmac-clock { > @@ -976,6 +986,11 @@ > vopb_out: port { > #address-cells = <1>; > #size-cells = <0>; > + > + vopb_out_lvds: endpoint@0 { > + reg = <0>; > + remote-endpoint = <&lvds_vopb_in>; > + }; This (and the one below) would create dangling phandle references and compile errors, because the referenced phandles only get introduced in patch12. So ideally merge this into the last patch. Heiko > }; > }; > > @@ -1008,6 +1023,11 @@ > vopl_out: port { > #address-cells = <1>; > #size-cells = <0>; > + > + vopl_out_lvds: endpoint@0 { > + reg = <0>; > + remote-endpoint = <&lvds_vopl_in>; > + }; > }; > }; > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62B32C34342 for ; Fri, 13 Dec 2019 20:40:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A05FD2477A for ; Fri, 13 Dec 2019 20:40:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728835AbfLMS2Z (ORCPT ); Fri, 13 Dec 2019 13:28:25 -0500 Received: from gloria.sntech.de ([185.11.138.130]:36696 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728807AbfLMS2Z (ORCPT ); Fri, 13 Dec 2019 13:28:25 -0500 Received: from ip5f5a6266.dynamic.kabel-deutschland.de ([95.90.98.102] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1ifpfq-0003GI-A5; Fri, 13 Dec 2019 19:28:22 +0100 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Miquel Raynal Cc: Rob Herring , Mark Rutland , devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org, Daniel Vetter , David Airlie , Sandy Huang , linux-arm-kernel@lists.infradead.org, Paul Kocialkowski , Maxime Chevallier , Thomas Petazzoni , dri-devel@lists.freedesktop.org Subject: Re: [PATCH 10/12] arm64: dts: rockchip: Add PX30 CRTCs graph LVDS endpoints Date: Fri, 13 Dec 2019 19:28:21 +0100 Message-ID: <1933192.L6hp5CucIl@diego> In-Reply-To: <20191213181051.25983-11-miquel.raynal@bootlin.com> References: <20191213181051.25983-1-miquel.raynal@bootlin.com> <20191213181051.25983-11-miquel.raynal@bootlin.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Miquel, Am Freitag, 13. Dezember 2019, 19:10:49 CET schrieb Miquel Raynal: > Add the display subsystem routes with the two available CRTCs: vopb > and vopl (big and little). For each CRTC, add the LVDS endpoints. MIPI > DSI endpoints will come later. > > Signed-off-by: Miquel Raynal > --- > arch/arm64/boot/dts/rockchip/px30.dtsi | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/arch/arm64/boot/dts/rockchip/px30.dtsi b/arch/arm64/boot/dts/rockchip/px30.dtsi > index b2af0f02ecbe..1c96ba556daf 100644 > --- a/arch/arm64/boot/dts/rockchip/px30.dtsi > +++ b/arch/arm64/boot/dts/rockchip/px30.dtsi > @@ -190,6 +190,16 @@ > compatible = "rockchip,display-subsystem"; > ports = <&vopb_out>, <&vopl_out>; > status = "disabled"; > + > + route { > + route_vopb_lvds: route-vopb-lvds { > + connect = <&vopb_out_lvds>; > + }; > + > + route_vopl_lvds: route-vopl-lvds { > + connect = <&vopl_out_lvds>; > + }; > + }; where does this route-stuff come from? The vendor tree? Because so far I've not seen this in mainline-drm in general nor the Rockchip drm driver itself. > }; > > gmac_clkin: external-gmac-clock { > @@ -976,6 +986,11 @@ > vopb_out: port { > #address-cells = <1>; > #size-cells = <0>; > + > + vopb_out_lvds: endpoint@0 { > + reg = <0>; > + remote-endpoint = <&lvds_vopb_in>; > + }; This (and the one below) would create dangling phandle references and compile errors, because the referenced phandles only get introduced in patch12. So ideally merge this into the last patch. Heiko > }; > }; > > @@ -1008,6 +1023,11 @@ > vopl_out: port { > #address-cells = <1>; > #size-cells = <0>; > + > + vopl_out_lvds: endpoint@0 { > + reg = <0>; > + remote-endpoint = <&lvds_vopl_in>; > + }; > }; > }; > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D20FCC4D2CA for ; Fri, 13 Dec 2019 20:54:57 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EAE672469F for ; Fri, 13 Dec 2019 20:54:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EAE672469F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B56296EBFF; Fri, 13 Dec 2019 18:28:43 +0000 (UTC) Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) by gabe.freedesktop.org (Postfix) with ESMTPS id EC7276EBFF for ; Fri, 13 Dec 2019 18:28:41 +0000 (UTC) Received: from ip5f5a6266.dynamic.kabel-deutschland.de ([95.90.98.102] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1ifpfq-0003GI-A5; Fri, 13 Dec 2019 19:28:22 +0100 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Miquel Raynal Subject: Re: [PATCH 10/12] arm64: dts: rockchip: Add PX30 CRTCs graph LVDS endpoints Date: Fri, 13 Dec 2019 19:28:21 +0100 Message-ID: <1933192.L6hp5CucIl@diego> In-Reply-To: <20191213181051.25983-11-miquel.raynal@bootlin.com> References: <20191213181051.25983-1-miquel.raynal@bootlin.com> <20191213181051.25983-11-miquel.raynal@bootlin.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Thomas Petazzoni , David Airlie , Sandy Huang , dri-devel@lists.freedesktop.org, Maxime Chevallier , Paul Kocialkowski , linux-rockchip@lists.infradead.org, Rob Herring , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Miquel, Am Freitag, 13. Dezember 2019, 19:10:49 CET schrieb Miquel Raynal: > Add the display subsystem routes with the two available CRTCs: vopb > and vopl (big and little). For each CRTC, add the LVDS endpoints. MIPI > DSI endpoints will come later. > > Signed-off-by: Miquel Raynal > --- > arch/arm64/boot/dts/rockchip/px30.dtsi | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/arch/arm64/boot/dts/rockchip/px30.dtsi b/arch/arm64/boot/dts/rockchip/px30.dtsi > index b2af0f02ecbe..1c96ba556daf 100644 > --- a/arch/arm64/boot/dts/rockchip/px30.dtsi > +++ b/arch/arm64/boot/dts/rockchip/px30.dtsi > @@ -190,6 +190,16 @@ > compatible = "rockchip,display-subsystem"; > ports = <&vopb_out>, <&vopl_out>; > status = "disabled"; > + > + route { > + route_vopb_lvds: route-vopb-lvds { > + connect = <&vopb_out_lvds>; > + }; > + > + route_vopl_lvds: route-vopl-lvds { > + connect = <&vopl_out_lvds>; > + }; > + }; where does this route-stuff come from? The vendor tree? Because so far I've not seen this in mainline-drm in general nor the Rockchip drm driver itself. > }; > > gmac_clkin: external-gmac-clock { > @@ -976,6 +986,11 @@ > vopb_out: port { > #address-cells = <1>; > #size-cells = <0>; > + > + vopb_out_lvds: endpoint@0 { > + reg = <0>; > + remote-endpoint = <&lvds_vopb_in>; > + }; This (and the one below) would create dangling phandle references and compile errors, because the referenced phandles only get introduced in patch12. So ideally merge this into the last patch. Heiko > }; > }; > > @@ -1008,6 +1023,11 @@ > vopl_out: port { > #address-cells = <1>; > #size-cells = <0>; > + > + vopl_out_lvds: endpoint@0 { > + reg = <0>; > + remote-endpoint = <&lvds_vopl_in>; > + }; > }; > }; > > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel