Re: [PATCH] S3C24XX: add clockevent/clocksource support

[Tomasz Figa <tomasz.figa@gmail.com>]

Hi Romain, Kgene,

On Sunday 25 of November 2012 03:54:51 Romain Naour wrote:
> Le 23/11/2012 03:30, Kukjin Kim a écrit :
> > Basically, looks good to me but need to edit commit message :-)
> 
> I will correct that.
> 
> > And since this touches many files so would be better if this could be
> > applied early -rc not now. It can provide more time to test for many
> > boards. Is it ok to you?
> 
> I'm ok :-)
> 
> > Thanks.
> > 
> > Best regards,
> > Kgene.
> > --
> > Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
> > SW Solution Development Team, Samsung Electronics Co., Ltd.
> 
> This patch was applied to 3.7-rc1 and tested only on s3c2440 (mini2440).
> I could re-apply this patch for the next 3.8-rc if you prefer.
> 
> I proposed this patch because I need to have clockevent / clocksource
> support to use Xenomai or Linux-rt on mini2440.
> 
> Since API clockevent/clocksource is enabled, we can use High Resolution
> Timer and Tickless mode. This can be interesting for the Linux side too.
> 
> Most of the work is already done in s5p-time.c (renamed samsung-time.c).
> I add some #define for s3c24xx case.

I would also suggest splitting this huge patch into a series of several 
smaller, possibly:
1) Rename s5p-time to samsung-time (and correct any platforms using it 
currently)
2) Add samsung-time support for s3c24xx
3) Add samsung-time support for s3c64xx

What do you think?

Best regards,
Tomasz Figa