All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: Claudio Fontana <cfontana@suse.de>
Cc: "Laurent Vivier" <lvivier@redhat.com>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Eduardo Habkost" <ehabkost@redhat.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"open list:X86 HAXM CPUs" <haxm-team@intel.com>,
	"Marcelo Tosatti" <mtosatti@redhat.com>,
	"open list:All patches CC here" <qemu-devel@nongnu.org>,
	"Roman Bolshakov" <r.bolshakov@yadro.com>,
	"Colin Xu" <colin.xu@intel.com>,
	"Wenchao Wang" <wenchao.wang@intel.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Sunil Muthuswamy" <sunilmut@microsoft.com>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"Richard Henderson" <rth@twiddle.net>
Subject: Re: [RFC 1/3] cpu-throttle: new module, extracted from cpus.c
Date: Fri, 22 May 2020 02:07:02 -0400 (EDT)	[thread overview]
Message-ID: <1934989075.27890087.1590127622669.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20200521185407.25311-2-cfontana@suse.de>

> From: "Claudio Fontana" <cfontana@suse.de>
> Sent: Thursday, May 21, 2020 8:54:05 PM
> 
> this is a first step in the refactoring of cpus.c.

Could you maybe extend the commit message in the next version a little bit? ... say something about *what* you are moving to a separate file (and maybe why it is ok to move it), etc.?

 Thanks,
  Thomas



  reply	other threads:[~2020-05-22  6:07 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-21 18:54 [RFC 0/3] QEMU cpus.c refactoring Claudio Fontana
2020-05-21 18:54 ` [RFC 1/3] cpu-throttle: new module, extracted from cpus.c Claudio Fontana
2020-05-22  6:07   ` Thomas Huth [this message]
2020-05-22  8:15     ` Claudio Fontana
2020-05-22 10:26       ` Alex Bennée
2020-05-22 10:54         ` Claudio Fontana
2020-05-22 11:18           ` Alex Bennée
2020-05-22 11:23             ` Claudio Fontana
2020-05-21 18:54 ` [RFC 2/3] cpu-timers: new module " Claudio Fontana
2020-05-22 13:49   ` Claudio Fontana
2020-05-21 18:54 ` [RFC 3/3] cpus: implement cpus interfaces for per-accel threads Claudio Fontana

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1934989075.27890087.1590127622669.JavaMail.zimbra@redhat.com \
    --to=thuth@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=cfontana@suse.de \
    --cc=colin.xu@intel.com \
    --cc=ehabkost@redhat.com \
    --cc=haxm-team@intel.com \
    --cc=lvivier@redhat.com \
    --cc=mtosatti@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=r.bolshakov@yadro.com \
    --cc=rth@twiddle.net \
    --cc=sunilmut@microsoft.com \
    --cc=wenchao.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.