From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from perceval.ideasonboard.com ([213.167.242.64]:44654 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030236AbeEXK6K (ORCPT ); Thu, 24 May 2018 06:58:10 -0400 From: Laurent Pinchart To: Kieran Bingham Cc: linux-renesas-soc@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH v4 05/11] media: vsp1: Clean up DLM objects on error Date: Thu, 24 May 2018 13:58:06 +0300 Message-ID: <1938981.0TdDEbag8f@avalon> In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: Hi Kieran, Thank you for the patch. On Thursday, 3 May 2018 16:36:16 EEST Kieran Bingham wrote: > If there is an error allocating a display list within a DLM object > the existing display lists are not free'd, and neither is the DL body > pool. > > Use the existing vsp1_dlm_destroy() function to clean up on error. > > Signed-off-by: Kieran Bingham Reviewed-by: Laurent Pinchart > --- > drivers/media/platform/vsp1/vsp1_dl.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/media/platform/vsp1/vsp1_dl.c > b/drivers/media/platform/vsp1/vsp1_dl.c index b23e88cda49f..fbffbd407b29 > 100644 > --- a/drivers/media/platform/vsp1/vsp1_dl.c > +++ b/drivers/media/platform/vsp1/vsp1_dl.c > @@ -851,8 +851,10 @@ struct vsp1_dl_manager *vsp1_dlm_create(struct > vsp1_device *vsp1, struct vsp1_dl_list *dl; > > dl = vsp1_dl_list_alloc(dlm); > - if (!dl) > + if (!dl) { > + vsp1_dlm_destroy(dlm); > return NULL; > + } > > list_add_tail(&dl->list, &dlm->free); > } -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v4 05/11] media: vsp1: Clean up DLM objects on error Date: Thu, 24 May 2018 13:58:06 +0300 Message-ID: <1938981.0TdDEbag8f@avalon> References: Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 052426E01C for ; Thu, 24 May 2018 10:58:10 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Kieran Bingham Cc: linux-renesas-soc@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org SGkgS2llcmFuLAoKVGhhbmsgeW91IGZvciB0aGUgcGF0Y2guCgpPbiBUaHVyc2RheSwgMyBNYXkg MjAxOCAxNjozNjoxNiBFRVNUIEtpZXJhbiBCaW5naGFtIHdyb3RlOgo+IElmIHRoZXJlIGlzIGFu IGVycm9yIGFsbG9jYXRpbmcgYSBkaXNwbGF5IGxpc3Qgd2l0aGluIGEgRExNIG9iamVjdAo+IHRo ZSBleGlzdGluZyBkaXNwbGF5IGxpc3RzIGFyZSBub3QgZnJlZSdkLCBhbmQgbmVpdGhlciBpcyB0 aGUgREwgYm9keQo+IHBvb2wuCj4gCj4gVXNlIHRoZSBleGlzdGluZyB2c3AxX2RsbV9kZXN0cm95 KCkgZnVuY3Rpb24gdG8gY2xlYW4gdXAgb24gZXJyb3IuCj4gCj4gU2lnbmVkLW9mZi1ieTogS2ll cmFuIEJpbmdoYW0gPGtpZXJhbi5iaW5naGFtK3JlbmVzYXNAaWRlYXNvbmJvYXJkLmNvbT4KClJl dmlld2VkLWJ5OiBMYXVyZW50IFBpbmNoYXJ0IDxsYXVyZW50LnBpbmNoYXJ0QGlkZWFzb25ib2Fy ZC5jb20+Cgo+IC0tLQo+ICBkcml2ZXJzL21lZGlhL3BsYXRmb3JtL3ZzcDEvdnNwMV9kbC5jIHwg NCArKystCj4gIDEgZmlsZSBjaGFuZ2VkLCAzIGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkK PiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS92c3AxL3ZzcDFfZGwuYwo+ IGIvZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS92c3AxL3ZzcDFfZGwuYyBpbmRleCBiMjNlODhjZGE0 OWYuLmZiZmZiZDQwN2IyOQo+IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvbWVkaWEvcGxhdGZvcm0v dnNwMS92c3AxX2RsLmMKPiArKysgYi9kcml2ZXJzL21lZGlhL3BsYXRmb3JtL3ZzcDEvdnNwMV9k bC5jCj4gQEAgLTg1MSw4ICs4NTEsMTAgQEAgc3RydWN0IHZzcDFfZGxfbWFuYWdlciAqdnNwMV9k bG1fY3JlYXRlKHN0cnVjdAo+IHZzcDFfZGV2aWNlICp2c3AxLCBzdHJ1Y3QgdnNwMV9kbF9saXN0 ICpkbDsKPiAKPiAgCQlkbCA9IHZzcDFfZGxfbGlzdF9hbGxvYyhkbG0pOwo+IC0JCWlmICghZGwp Cj4gKwkJaWYgKCFkbCkgewo+ICsJCQl2c3AxX2RsbV9kZXN0cm95KGRsbSk7Cj4gIAkJCXJldHVy biBOVUxMOwo+ICsJCX0KPiAKPiAgCQlsaXN0X2FkZF90YWlsKCZkbC0+bGlzdCwgJmRsbS0+ZnJl ZSk7Cj4gIAl9CgoKLS0gClJlZ2FyZHMsCgpMYXVyZW50IFBpbmNoYXJ0CgoKCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxp c3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNr dG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=