Re: [PATCH v4 1/3] powerpc/nvram: move generic code for nvram and pstore

[Arnd Bergmann <arnd@arndb.de>]

On Friday 30 January 2015 20:44:00 Hari Bathini wrote:
> With minor checks, we can move most of the code for nvram
> under pseries to a common place to be re-used by other
> powerpc platforms like powernv. This patch moves such
> common code to arch/powerpc/kernel/nvram_64.c file.
> 
> Signed-off-by: Hari Bathini <hbathini@linux.vnet.ibm.com>

Can you make this y2038-safe in the process, possibly as a
follow-up patch?

> +extern unsigned long last_rtas_event;

time64_t

> +	}
> +	oops_hdr->version = cpu_to_be16(OOPS_HDR_VERSION);
> +	oops_hdr->report_length = cpu_to_be16(zipped_len);
> +	oops_hdr->timestamp = cpu_to_be64(get_seconds());
> +	return 0;

ktime_get_real_seconds()

> +static ssize_t nvram_pstore_read(u64 *id, enum pstore_type_id *type,
> +				int *count, struct timespec *time, char **buf,
> +				bool *compressed, struct pstore_info *psi)

This has to remain timespec for now but can later be changed to timespec64
when the API gets changed.

> +		oops_hdr->version = cpu_to_be16(OOPS_HDR_VERSION);
> +		oops_hdr->report_length = cpu_to_be16(text_len);
> +		oops_hdr->timestamp = cpu_to_be64(get_seconds());

ktime_get_real_seconds()

	Arnd