From mboxrd@z Thu Jan 1 00:00:00 1970 From: Janusz Krzysztofik Subject: Re: [PATCH] ASoC: ams-delta: fix card initalization failure Date: Sat, 01 Sep 2012 11:09:18 +0200 Message-ID: <1939338.OUN9Uq58XY@vclass> References: <1346102910-8610-1-git-send-email-jkrzyszt@tis.icnet.pl> <1809544.cvZPIRmRr5@acer> <20120831213103.GC5495@opensource.wolfsonmicro.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from d1.icnet.pl (d1.icnet.pl [212.160.220.21]) by alsa0.perex.cz (Postfix) with ESMTP id 89E4A265E27 for ; Sat, 1 Sep 2012 11:29:46 +0200 (CEST) In-Reply-To: <20120831213103.GC5495@opensource.wolfsonmicro.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: alsa-devel@alsa-project.org Cc: linux-omap@vger.kernel.org, Mark Brown , Liam Girdwood , linux-kernel@vger.kernel.org List-Id: alsa-devel@alsa-project.org RG5pYSBwacSFdGVrLCAzMSBzaWVycG5pYSAyMDEyIDE0OjMxOjA0IE1hcmsgQnJvd24gcGlzemU6 Cj4gT24gV2VkLCBBdWcgMjksIDIwMTIgYXQgMDc6MDQ6NDhBTSArMDIwMCwgSmFudXN6IEtyenlz enRvZmlrIHdyb3RlOgo+ID4gT24gVHVlLCAyOCBBdWcgMjAxMiAxMToxMzozOSBNYXJrIEJyb3du IHdyb3RlOgo+IAo+ID4gPiBUaGUgYWJvdmUgbG9va3MgbGlrZSB5b3UgYWxyZWFkeSBoYXZlIGEg cGxhdGZvcm0gZHJpdmVyPyAKCk1hcmssCkkgc2hvdWxkIGhhdmUgcmF0aGVyIGFuc3dlcmVkOiBO bywgYW1zLWRlbHRhLmMgaXMgbm90IGEgcGxhdGZvcm0gZHJpdmVyLCAKb25seSBhIG1vZHVsZSB3 aGljaCByZWdpc3RlcmVzIGEgc29jLWF1ZGlvIGRldmljZSBhbmQgcHJvdmlkZXMgZGV2aWNlIApz cGVjaWZpYyBkYXRhIGFuZCBjYWxsYmFja3MgdG8gdGhlIHNvYy1hdWRpbyBwbGF0Zm9ybSBkcml2 ZXIuCgo+ID4gPiBBbGwgSSdtCj4gPiA+IHN1Z2dlc3RpbmcgaXMgY2hhbmdpbmcgdGhlIGFib3Zl IHRvIHVzZSBwbGF0Zm9ybSByYXRoZXIgdGhhbiAKZHJpdmVyCj4gPiA+IGRhdGEuCj4gLi4uCj4g cy9kcnZkYXRhL3BsYXRkYXRhLyBpbiB0aGUgY29kZS4gCgpUYWtpbmcgdGhlIGFib3ZlIGludG8g YWNjb3VudCwgSSB3b3VsZCBoYXZlIHRvIGFwcGx5IHRoaXMgc3Vic3RpdHVlIHRvIAp0aGUgc29j LWNvcmUuYywgd2hpY2ggaXMgYWN0dWFsbHkgdGhlIHBsYXRmb3JtIGRyaXZlciBmb3IgdGhlIGFt cy1kZWx0YSAKQVNvQyBkZXZpY2UsIGFuZCB0aGlzIHdvdWxkIGJyZWFrIGEgbG90IG9mIG90aGVy IGNhcmRzLgoKPiBJZiB5b3UgY2FuJ3QgZG8gdGhpcyB0aGVuIGp1c3QKPiByZWZlcmVuY2luZyB0 aGUgZGF0YSBkaXJlY3RseSBpbiB0aGUgY29kZSB3b3VsZCBiZSBiZXR0ZXIgdGhhbiB0aGlzCj4g Ym9kZ2UsIGl0J2QgYmUgbXVjaCBsZXNzIGZyYWdpbGUuCgpJIHNlZSB5b3VyIHBvaW50LCBob3dl dmVyIGZvciBub3cgSSBjYW4gc2VlIG5vIGJldHRlciB3YXkgb2YgcmVmZXJlbmNpbmcgCnRoZSBk YXRhIChvZiB0eXBlIHN0cnVjdCBzbmRfc29jX2NhcmQpIHRoZW4gcGFzc2luZyBpdCB0byAKc25k X3NvY19yZWdpc3Rlcl9jYXJkKCkuIEJ1dCBmb3IgdGhpcyB0byB3b3JrLCBJIHdvdWxkIGhhdmUg dG8gcmVnaXN0ZXIgCnN1Y2Nlc3NmdWxseSBhbiBhbXMtZGVsdGEgc3BlY2lmaWMgcGxhdGZvcm0g ZGV2aWNlIGZpcnN0LCBub3QgdGhlIHNvYy0KYXVkaW8uIFRoaXMsIGV2ZW4gaWYgc3RpbGwgZG9u ZSBmcm9tIHRoZSBzb3VuZC9zb2Mvb21hcC9hbXMtZGVsdGEuYywgbm90IApmcm9tIGFuIGFyY2gg Ym9hcmQgZmlsZSwgd291bGQgcmVxdWlyZSBub3cgbm90IGV4aXN0aW5nIGFtcy1kZWx0YSBBU29D IApwbGF0Zm9ybSBkcml2ZXIgcHJvYmUvcmVtb3ZlIGNhbGxiYWNrcyBhdCBsZWFzdC4gSSdtIHN0 aWxsIG5vdCBjb252aW5jZWQgCmlmIHN1Y2ggbW9kaWZpY2F0aW9uIHdvdWxkIGJlIGFjY2VwdGFi bGUgaW4gdGhlIG1pZGRsZSBvZiB0aGUgcmMgY3ljbGUuCgpJZiB0aGVyZSBpcyBhIHNpbXBsZXIs IGxlc3MgaW50cnVzaXZlIHdheSB0byBkbyB0aGlzLCB0aGVuIHNvcnJ5LCBJIApzdGlsbCBjYW4n dCBzZWUgaXQuCgpUaGFua3MsCkphbnVzegpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpBbHNhLWRldmVsIG1haWxpbmcgbGlzdApBbHNhLWRldmVsQGFsc2Et cHJvamVjdC5vcmcKaHR0cDovL21haWxtYW4uYWxzYS1wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2Fsc2EtZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754405Ab2IAJ3t (ORCPT ); Sat, 1 Sep 2012 05:29:49 -0400 Received: from d1.icnet.pl ([212.160.220.21]:47708 "EHLO d1.icnet.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753102Ab2IAJ3s convert rfc822-to-8bit (ORCPT ); Sat, 1 Sep 2012 05:29:48 -0400 From: Janusz Krzysztofik To: alsa-devel@alsa-project.org Cc: Mark Brown , linux-omap@vger.kernel.org, Liam Girdwood , linux-kernel@vger.kernel.org Subject: Re: [alsa-devel] [PATCH] ASoC: ams-delta: fix card initalization failure Date: Sat, 01 Sep 2012 11:09:18 +0200 Message-ID: <1939338.OUN9Uq58XY@vclass> Organization: Tele-Info-System, Poznan, PL User-Agent: KMail/4.8.3 (Linux/3.1.10-gentoo-r1; KDE/4.8.3; i686; ; ) In-Reply-To: <20120831213103.GC5495@opensource.wolfsonmicro.com> References: <1346102910-8610-1-git-send-email-jkrzyszt@tis.icnet.pl> <1809544.cvZPIRmRr5@acer> <20120831213103.GC5495@opensource.wolfsonmicro.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="utf-8" X-SA-Exim-Scanned: No (on d1.icnet); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dnia piątek, 31 sierpnia 2012 14:31:04 Mark Brown pisze: > On Wed, Aug 29, 2012 at 07:04:48AM +0200, Janusz Krzysztofik wrote: > > On Tue, 28 Aug 2012 11:13:39 Mark Brown wrote: > > > > The above looks like you already have a platform driver? Mark, I should have rather answered: No, ams-delta.c is not a platform driver, only a module which registeres a soc-audio device and provides device specific data and callbacks to the soc-audio platform driver. > > > All I'm > > > suggesting is changing the above to use platform rather than driver > > > data. > ... > s/drvdata/platdata/ in the code. Taking the above into account, I would have to apply this substitue to the soc-core.c, which is actually the platform driver for the ams-delta ASoC device, and this would break a lot of other cards. > If you can't do this then just > referencing the data directly in the code would be better than this > bodge, it'd be much less fragile. I see your point, however for now I can see no better way of referencing the data (of type struct snd_soc_card) then passing it to snd_soc_register_card(). But for this to work, I would have to register successfully an ams-delta specific platform device first, not the soc- audio. This, even if still done from the sound/soc/omap/ams-delta.c, not from an arch board file, would require now not existing ams-delta ASoC platform driver probe/remove callbacks at least. I'm still not convinced if such modification would be acceptable in the middle of the rc cycle. If there is a simpler, less intrusive way to do this, then sorry, I still can't see it. Thanks, Janusz