From: Thomas Monjalon <thomas@monjalon.net>
To: akhil.goyal@nxp.com, fiona.trahe@intel.com, arkadiuszx.kusztal@intel.com
Cc: dev@dpdk.org, ferruh.yigit@intel.com, bruce.richardson@intel.com,
orika@mellanox.com, jerinj@marvell.com,
stephen@networkplumber.org, olivier.matz@6wind.com,
hemant.agrawal@nxp.com, mdr@ashroe.eu
Subject: Re: [dpdk-dev] [PATCH v2] cryptodev: add function to check if qp was setup
Date: Wed, 08 Jul 2020 15:37:44 +0200 [thread overview]
Message-ID: <1939387.ZpZeW6HBnj@thomas> (raw)
In-Reply-To: <20200624142653.16488-1-arkadiuszx.kusztal@intel.com>
24/06/2020 16:26, Arek Kusztal:
> From: Fiona Trahe <fiona.trahe@intel.com>
>
> This patch adds function that can check if queue pair
> was already setup. This may be useful when dealing with
> multi process approach in cryptodev.
That's all? No more justification?
No usage in example apps?
No addition in test apps?
Is it needed for the application?
I don't know cryptodev enough, but I can tell with ethdev experience
that we are a lot more demanding when adding a new API in ethdev.
We are still fixing the API errors done years ago in ethdev,
and it is very difficult to deprecate what was used in the past.
I hope my fear is wrong and you are not doing the same errors
as we did in ethdev, it would be a pity.
next prev parent reply other threads:[~2020-07-08 13:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-24 14:26 [dpdk-dev] [PATCH v2] cryptodev: add function to check if qp was setup Arek Kusztal
2020-07-02 17:50 ` Akhil Goyal
2020-07-03 14:08 ` Kusztal, ArkadiuszX
2020-07-04 20:11 ` Akhil Goyal
2020-07-08 13:37 ` Thomas Monjalon [this message]
2020-07-08 14:05 ` Akhil Goyal
2020-07-08 14:10 ` Trahe, Fiona
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1939387.ZpZeW6HBnj@thomas \
--to=thomas@monjalon.net \
--cc=akhil.goyal@nxp.com \
--cc=arkadiuszx.kusztal@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=fiona.trahe@intel.com \
--cc=hemant.agrawal@nxp.com \
--cc=jerinj@marvell.com \
--cc=mdr@ashroe.eu \
--cc=olivier.matz@6wind.com \
--cc=orika@mellanox.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.