From: Thomas Monjalon <thomas@monjalon.net>
To: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Cc: dev@dpdk.org, david.marchand@redhat.com, ferruh.yigit@intel.com,
grive@u256.net, alvinx.zhang@intel.com, beilei.xing@intel.com,
jia.guo@intel.com, anatoly.burakov@intel.com,
bruce.richardson@intel.com, navasile@linux.microsoft.com,
dmitrym@microsoft.com, pallavi.kadam@intel.com,
talshn@mellanox.com
Subject: Re: [dpdk-dev] [PATCH] pci: keep API compatibility with mmap values
Date: Fri, 10 Jul 2020 22:02:50 +0200 [thread overview]
Message-ID: <1939625.Z6HycuXOoL@thomas> (raw)
In-Reply-To: <20200710213155.7db798b7@sovereign>
10/07/2020 20:31, Dmitry Kozlyuk:
> On Fri, 10 Jul 2020 13:53:24 +0200, Thomas Monjalon wrote:
> > --- /dev/null
> > +++ b/lib/librte_eal/windows/include/sys/mman.h
> > @@ -0,0 +1,9 @@
> > +/* SPDX-License-Identifier: BSD-3-Clause
> > + * Copyright 2020 Mellanox Technologies, Ltd
> > + */
> > +
> > +/*
> > + * The syscall mmap does not exist on Windows,
> > + * but this error code is used in a badly defined DPDK API for PCI mapping.
> > + */
> > +#define MAP_FAILED ((void *) -1)
>
> I see why we can't help exposing <sys/mman.h> in <rte_eal_paging.h>, but I'm
> against adding this stub header. Why not make #include <sys/mman.h>
> conditional and define MAP_FAIELD in <rte_os.h> for Windows?
Yes this macro can be in lib/librte_eal/windows/include/rte_os.h
I'll do a v2.
next prev parent reply other threads:[~2020-07-10 20:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-10 11:53 [dpdk-dev] [PATCH] pci: keep API compatibility with mmap values Thomas Monjalon
2020-07-10 13:34 ` David Marchand
2020-07-10 15:39 ` Burakov, Anatoly
2020-07-10 16:17 ` Thomas Monjalon
2020-07-13 8:56 ` Burakov, Anatoly
2020-07-15 8:01 ` David Marchand
2020-07-10 17:10 ` Thomas Monjalon
2020-07-10 18:31 ` Dmitry Kozlyuk
2020-07-10 20:02 ` Thomas Monjalon [this message]
2020-07-10 20:40 ` [dpdk-dev] [PATCH v2] " Thomas Monjalon
2020-07-10 21:07 ` Dmitry Kozlyuk
2020-07-11 9:51 ` Thomas Monjalon
2020-07-11 3:27 ` Ma, LihongX
2020-07-11 9:50 ` Thomas Monjalon
2020-07-11 3:18 ` [dpdk-dev] [PATCH] " Ma, LihongX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1939625.Z6HycuXOoL@thomas \
--to=thomas@monjalon.net \
--cc=alvinx.zhang@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=beilei.xing@intel.com \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=dmitrym@microsoft.com \
--cc=ferruh.yigit@intel.com \
--cc=grive@u256.net \
--cc=jia.guo@intel.com \
--cc=navasile@linux.microsoft.com \
--cc=pallavi.kadam@intel.com \
--cc=talshn@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.