All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org, Reshma Pattan <reshma.pattan@intel.com>,
	Luca Boccassi <bluca@debian.org>
Subject: Re: [PATCH] test: fix 32 bit overflow in pcapng test
Date: Mon, 29 Jul 2024 18:33:11 +0200	[thread overview]
Message-ID: <1939808.6tgchFWduM@thomas> (raw)
In-Reply-To: <CAMw=ZnSqhygtTo+jLe3jt9QRSOXMxDgwbta-oJyC6QBBQcByZw@mail.gmail.com>

18/07/2024 21:07, Luca Boccassi:
> On Thu, 18 Jul 2024 at 18:43, Stephen Hemminger
> <stephen@networkplumber.org> wrote:
> >
> > The conversion from seconds to nanoseconds in the pcapng test
> > would overflow on 32 bit platforms leading to this test failing.
> >
> > Reported-by: Luca Boccassi <bluca@debian.org>
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> > ---
> > -       ns = h->ts.tv_sec * NS_PER_S + h->ts.tv_usec;
> > +       ns = (uint64_t)h->ts.tv_sec * NS_PER_S + h->ts.tv_usec;
> 
> Thanks this fixes the issue, the build is now green
> 
> Tested-by: Luca Boccassi <bluca@debian.org>

Applied, thanks.



      reply	other threads:[~2024-07-29 16:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-18 17:42 [PATCH] test: fix 32 bit overflow in pcapng test Stephen Hemminger
2024-07-18 19:07 ` Luca Boccassi
2024-07-29 16:33   ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1939808.6tgchFWduM@thomas \
    --to=thomas@monjalon.net \
    --cc=bluca@debian.org \
    --cc=dev@dpdk.org \
    --cc=reshma.pattan@intel.com \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.