From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: "Xie, Huawei" <huawei.xie-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: dev-VfR2kkLFssw@public.gmane.org
Subject: Re: [PATCH v5 01/11] lib/librte_vhost: move src files in vhost example to vhost lib directory
Date: Tue, 30 Sep 2014 06:35:04 +0200 [thread overview]
Message-ID: <1939857.K6XTWT658S@xps13> (raw)
In-Reply-To: <C37D651A908B024F974696C65296B57B0F2AF246-0J0gbvR4kThpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-09-30 02:07, Xie, Huawei:
> > In patch 2, you're using main.c to create vhost_rxtx.c.
> > So it would be clearer to rename it in this patch 1.
> >
> Rename it to vhost_rxtx.c?
Yes :)
And rename virtio-net.h to rte_virtio_net.h.
Please put all file renaming in the same patch.
Then second patch should be definitive removals.
>From the third patch, you can start reworks.
--
Thomas
next prev parent reply other threads:[~2014-09-30 4:35 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-26 9:45 [PATCH v5 00/11] user space vhost library and vhost example Huawei Xie
[not found] ` <1411724758-27488-1-git-send-email-huawei.xie-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-09-26 9:45 ` [PATCH v5 01/11] lib/librte_vhost: move src files in vhost example to vhost lib directory Huawei Xie
[not found] ` <1411724758-27488-2-git-send-email-huawei.xie-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-09-29 19:41 ` Thomas Monjalon
2014-09-30 2:07 ` Xie, Huawei
[not found] ` <C37D651A908B024F974696C65296B57B0F2AF246-0J0gbvR4kThpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-09-30 4:35 ` Thomas Monjalon [this message]
2014-09-26 9:45 ` [PATCH v5 02/11] lib/librte_vhost: refactor vhost lib for subsequent transform Huawei Xie
[not found] ` <1411724758-27488-3-git-send-email-huawei.xie-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-09-29 19:55 ` Thomas Monjalon
2014-09-29 20:00 ` Thomas Monjalon
2014-09-26 9:45 ` [PATCH v5 03/11] lib/librte_vhost: vhost lib transform Huawei Xie
[not found] ` <1411724758-27488-4-git-send-email-huawei.xie-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-09-29 19:51 ` Thomas Monjalon
2014-09-26 9:45 ` [PATCH v5 04/11] lib/librte_vhost: merge vhost merge-able rx. merge vhost tx fix Huawei Xie
2014-09-26 9:45 ` [PATCH v5 05/11] lib/librte_vhost: merge Oliver's mbuf change Huawei Xie
[not found] ` <1411724758-27488-6-git-send-email-huawei.xie-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-09-29 19:44 ` Thomas Monjalon
2014-09-30 2:41 ` Xie, Huawei
[not found] ` <C37D651A908B024F974696C65296B57B0F2AF2C0-0J0gbvR4kThpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-09-30 3:41 ` Ouyang, Changchun
2014-09-30 4:46 ` Thomas Monjalon
2014-09-30 6:43 ` Xie, Huawei
[not found] ` <C37D651A908B024F974696C65296B57B0F2AF638-0J0gbvR4kThpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-09-30 8:06 ` Thomas Monjalon
2014-09-26 9:45 ` [PATCH v5 06/11] lib/librte_vhost: fixes serious coding style issues Huawei Xie
2014-09-26 9:45 ` [PATCH v5 07/11] lib/librte_vhost: add vhost support in DPDK makefile Huawei Xie
2014-09-26 9:45 ` [PATCH v5 08/11] examples/vhost: copy old vhost example src file Huawei Xie
2014-09-26 9:45 ` [PATCH v5 09/11] examples/vhost: vhost example based on vhost lib API Huawei Xie
2014-09-26 9:45 ` [PATCH v5 10/11] examples/vhost: merge oliver's mbuf changes to vhost example Huawei Xie
2014-09-26 9:45 ` [PATCH v5 11/11] examples/vhost: add vhost example Makefile Huawei Xie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1939857.K6XTWT658S@xps13 \
--to=thomas.monjalon-pdr9zngts4eavxtiumwx3w@public.gmane.org \
--cc=dev-VfR2kkLFssw@public.gmane.org \
--cc=huawei.xie-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.