From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chao Du Date: Fri, 22 Dec 2023 16:28:12 +0800 (GMT+08:00) Subject: [RFC PATCH 0/3] RISC-V: KVM: Guest Debug Support In-Reply-To: References: <20231221095002.7404-1-duchao@eswincomputing.com> Message-ID: <19434eff.1deb.18c90a3a375.Coremail.duchao@eswincomputing.com> List-Id: To: kvm-riscv@lists.infradead.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On 2023-12-21 21:01, Anup Patel wrote: > > On Thu, Dec 21, 2023 at 3:21?PM Chao Du wrote: > > > > This series implements KVM Guest Debug on RISC-V. Currently, we can > > debug RISC-V KVM guest from the host side, with software breakpoints. > > > > A brief test was done on QEMU RISC-V hypervisor emulator. > > > > A TODO list which will be added later: > > 1. HW breakpoints support > > 2. Test cases > > Himanshu has already done the complete HW breakpoint implementation > in OpenSBI, Linux RISC-V, and KVM RISC-V. This is based on the upcoming > SBI debug trigger extension draft proposal. > (Refer, https://lists.riscv.org/g/tech-debug/message/1261) > > There are also RISE projects to track these efforts: > https://wiki.riseproject.dev/pages/viewpage.action?pageId=394541 > https://wiki.riseproject.dev/pages/viewpage.action?pageId=394545 > > Currently, we are in the process of upstreaming the OpenSBI support > for SBI debug trigger extension. The Linux RISC-V and KVM RISC-V > patches require SBI debug trigger extension and Sdtrig extension to > be frozen which will happen next year 2024. > > Regards, > Anup > Hi Anup, Thank you for the information and your great work on the SBI Debug Trigger Extension proposal. So I think that 'HW breakpoints support' in the above TODO list will be taken care of by Himanshu following the extension proposal. On the other hand, if I understand correctly, the software breakpoint part of KVM Guest Debug has no dependency on the new extension since it does not use the trigger module. Just an ebreak substitution is made. So may I know your suggestion about this RFC? Both in KVM and QEMU. Regards, Chao > > > > This series is based on Linux 6.7-rc6 and is also available at: > > https://github.com/Du-Chao/linux/tree/riscv_gd_sw > > > > The matched QEMU is available at: > > https://github.com/Du-Chao/qemu/tree/riscv_gd_sw > > > > Chao Du (3): > > RISC-V: KVM: Enable the KVM_CAP_SET_GUEST_DEBUG capability > > RISC-V: KVM: Implement kvm_arch_vcpu_ioctl_set_guest_debug() > > RISC-V: KVM: Handle breakpoint exits for VCPU > > > > arch/riscv/include/uapi/asm/kvm.h | 1 + > > arch/riscv/kvm/vcpu.c | 15 +++++++++++++-- > > arch/riscv/kvm/vcpu_exit.c | 4 ++++ > > arch/riscv/kvm/vm.c | 1 + > > 4 files changed, 19 insertions(+), 2 deletions(-) > > > > -- > > 2.17.1 > > > > > > -- > > kvm-riscv mailing list > > kvm-riscv at lists.infradead.org > > http://lists.infradead.org/mailman/listinfo/kvm-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sgoci-sdnproxy-4.icoremail.net (sgoci-sdnproxy-4.icoremail.net [129.150.39.64]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6C36FD2E0 for ; Fri, 22 Dec 2023 08:30:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=eswincomputing.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=eswincomputing.com Received: from duchao$eswincomputing.com ( [123.139.59.82] ) by ajax-webmail-app2 (Coremail) ; Fri, 22 Dec 2023 16:28:12 +0800 (GMT+08:00) Date: Fri, 22 Dec 2023 16:28:12 +0800 (GMT+08:00) X-CM-HeaderCharset: UTF-8 From: "Chao Du" To: "Anup Patel" Cc: kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, anup@brainfault.org, atishp@atishpatra.org, dbarboza@ventanamicro.com, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu Subject: Re: [RFC PATCH 0/3] RISC-V: KVM: Guest Debug Support X-Priority: 3 X-Mailer: Coremail Webmail Server Version XT6.0.3 build 20220420(169d3f8c) Copyright (c) 2002-2023 www.mailtech.cn mispb-72143050-eaf5-4703-89e0-86624513b4ce-eswincomputing.com In-Reply-To: References: <20231221095002.7404-1-duchao@eswincomputing.com> Content-Transfer-Encoding: base64 Content-Type: text/plain; charset=UTF-8 Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-ID: <19434eff.1deb.18c90a3a375.Coremail.duchao@eswincomputing.com> X-Coremail-Locale: en_US X-CM-TRANSID:TQJkCgBX5tScSIVlKrMCAA--.2850W X-CM-SenderInfo: xgxfxt3r6h245lqf0zpsxwx03jof0z/1tbiAQENDGWEWng11AACsh X-Coremail-Antispam: 1Ur529EdanIXcx71UUUUU7IcSsGvfJ3iIAIbVAYjsxI4VWxJw CS07vEb4IE77IF4wCS07vE1I0E4x80FVAKz4kxMIAIbVAFxVCaYxvI4VCIwcAKzIAtYxBI daVFxhVjvjDU= T24gMjAyMy0xMi0yMSAyMTowMSwgQW51cCBQYXRlbCA8YXBhdGVsQHZlbnRhbmFtaWNyby5jb20+ IHdyb3RlOgo+IAo+IE9uIFRodSwgRGVjIDIxLCAyMDIzIGF0IDM6MjHigK9QTSBDaGFvIER1IDxk dWNoYW9AZXN3aW5jb21wdXRpbmcuY29tPiB3cm90ZToKPiA+Cj4gPiBUaGlzIHNlcmllcyBpbXBs ZW1lbnRzIEtWTSBHdWVzdCBEZWJ1ZyBvbiBSSVNDLVYuIEN1cnJlbnRseSwgd2UgY2FuCj4gPiBk ZWJ1ZyBSSVNDLVYgS1ZNIGd1ZXN0IGZyb20gdGhlIGhvc3Qgc2lkZSwgd2l0aCBzb2Z0d2FyZSBi cmVha3BvaW50cy4KPiA+Cj4gPiBBIGJyaWVmIHRlc3Qgd2FzIGRvbmUgb24gUUVNVSBSSVNDLVYg aHlwZXJ2aXNvciBlbXVsYXRvci4KPiA+Cj4gPiBBIFRPRE8gbGlzdCB3aGljaCB3aWxsIGJlIGFk ZGVkIGxhdGVyOgo+ID4gMS4gSFcgYnJlYWtwb2ludHMgc3VwcG9ydAo+ID4gMi4gVGVzdCBjYXNl cwo+IAo+IEhpbWFuc2h1IGhhcyBhbHJlYWR5IGRvbmUgdGhlIGNvbXBsZXRlIEhXIGJyZWFrcG9p bnQgaW1wbGVtZW50YXRpb24KPiBpbiBPcGVuU0JJLCBMaW51eCBSSVNDLVYsIGFuZCBLVk0gUklT Qy1WLiBUaGlzIGlzIGJhc2VkIG9uIHRoZSB1cGNvbWluZwo+IFNCSSBkZWJ1ZyB0cmlnZ2VyIGV4 dGVuc2lvbiBkcmFmdCBwcm9wb3NhbC4KPiAoUmVmZXIsIGh0dHBzOi8vbGlzdHMucmlzY3Yub3Jn L2cvdGVjaC1kZWJ1Zy9tZXNzYWdlLzEyNjEpCj4gCj4gVGhlcmUgYXJlIGFsc28gUklTRSBwcm9q ZWN0cyB0byB0cmFjayB0aGVzZSBlZmZvcnRzOgo+IGh0dHBzOi8vd2lraS5yaXNlcHJvamVjdC5k ZXYvcGFnZXMvdmlld3BhZ2UuYWN0aW9uP3BhZ2VJZD0zOTQ1NDEKPiBodHRwczovL3dpa2kucmlz ZXByb2plY3QuZGV2L3BhZ2VzL3ZpZXdwYWdlLmFjdGlvbj9wYWdlSWQ9Mzk0NTQ1Cj4gCj4gQ3Vy cmVudGx5LCB3ZSBhcmUgaW4gdGhlIHByb2Nlc3Mgb2YgdXBzdHJlYW1pbmcgdGhlIE9wZW5TQkkg c3VwcG9ydAo+IGZvciBTQkkgZGVidWcgdHJpZ2dlciBleHRlbnNpb24uIFRoZSBMaW51eCBSSVND LVYgYW5kIEtWTSBSSVNDLVYKPiBwYXRjaGVzIHJlcXVpcmUgU0JJIGRlYnVnIHRyaWdnZXIgZXh0 ZW5zaW9uIGFuZCBTZHRyaWcgZXh0ZW5zaW9uIHRvCj4gYmUgZnJvemVuIHdoaWNoIHdpbGwgaGFw cGVuIG5leHQgeWVhciAyMDI0Lgo+IAo+IFJlZ2FyZHMsCj4gQW51cAo+IAoKSGkgQW51cCwKClRo YW5rIHlvdSBmb3IgdGhlIGluZm9ybWF0aW9uIGFuZCB5b3VyIGdyZWF0IHdvcmsgb24gdGhlIFNC SQpEZWJ1ZyBUcmlnZ2VyIEV4dGVuc2lvbiBwcm9wb3NhbC4KClNvIEkgdGhpbmsgdGhhdCAnSFcg YnJlYWtwb2ludHMgc3VwcG9ydCcgaW4gdGhlIGFib3ZlIFRPRE8gbGlzdAp3aWxsIGJlIHRha2Vu IGNhcmUgb2YgYnkgSGltYW5zaHUgZm9sbG93aW5nIHRoZSBleHRlbnNpb24gcHJvcG9zYWwuCgpP biB0aGUgb3RoZXIgaGFuZCwgaWYgSSB1bmRlcnN0YW5kIGNvcnJlY3RseSwgdGhlIHNvZnR3YXJl CmJyZWFrcG9pbnQgcGFydCBvZiBLVk0gR3Vlc3QgRGVidWcgaGFzIG5vIGRlcGVuZGVuY3kgb24g dGhlIG5ldwpleHRlbnNpb24gc2luY2UgaXQgZG9lcyBub3QgdXNlIHRoZSB0cmlnZ2VyIG1vZHVs ZS4gSnVzdCBhbgplYnJlYWsgc3Vic3RpdHV0aW9uIGlzIG1hZGUuCgpTbyBtYXkgSSBrbm93IHlv dXIgc3VnZ2VzdGlvbiBhYm91dCB0aGlzIFJGQz8gQm90aCBpbiBLVk0gYW5kIFFFTVUuCgpSZWdh cmRzLApDaGFvCgo+ID4KPiA+IFRoaXMgc2VyaWVzIGlzIGJhc2VkIG9uIExpbnV4IDYuNy1yYzYg YW5kIGlzIGFsc28gYXZhaWxhYmxlIGF0Ogo+ID4gaHR0cHM6Ly9naXRodWIuY29tL0R1LUNoYW8v bGludXgvdHJlZS9yaXNjdl9nZF9zdwo+ID4KPiA+IFRoZSBtYXRjaGVkIFFFTVUgaXMgYXZhaWxh YmxlIGF0Ogo+ID4gaHR0cHM6Ly9naXRodWIuY29tL0R1LUNoYW8vcWVtdS90cmVlL3Jpc2N2X2dk X3N3Cj4gPgo+ID4gQ2hhbyBEdSAoMyk6Cj4gPiAgIFJJU0MtVjogS1ZNOiBFbmFibGUgdGhlIEtW TV9DQVBfU0VUX0dVRVNUX0RFQlVHIGNhcGFiaWxpdHkKPiA+ICAgUklTQy1WOiBLVk06IEltcGxl bWVudCBrdm1fYXJjaF92Y3B1X2lvY3RsX3NldF9ndWVzdF9kZWJ1ZygpCj4gPiAgIFJJU0MtVjog S1ZNOiBIYW5kbGUgYnJlYWtwb2ludCBleGl0cyBmb3IgVkNQVQo+ID4KPiA+ICBhcmNoL3Jpc2N2 L2luY2x1ZGUvdWFwaS9hc20va3ZtLmggfCAgMSArCj4gPiAgYXJjaC9yaXNjdi9rdm0vdmNwdS5j ICAgICAgICAgICAgIHwgMTUgKysrKysrKysrKysrKy0tCj4gPiAgYXJjaC9yaXNjdi9rdm0vdmNw dV9leGl0LmMgICAgICAgIHwgIDQgKysrKwo+ID4gIGFyY2gvcmlzY3Yva3ZtL3ZtLmMgICAgICAg ICAgICAgICB8ICAxICsKPiA+ICA0IGZpbGVzIGNoYW5nZWQsIDE5IGluc2VydGlvbnMoKyksIDIg ZGVsZXRpb25zKC0pCj4gPgo+ID4gLS0KPiA+IDIuMTcuMQo+ID4KPiA+Cj4gPiAtLQo+ID4ga3Zt LXJpc2N2IG1haWxpbmcgbGlzdAo+ID4ga3ZtLXJpc2N2QGxpc3RzLmluZnJhZGVhZC5vcmcKPiA+ IGh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8va3ZtLXJpc2N2Cg==