From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: Olivier MATZ <olivier.matz-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Cc: dev-VfR2kkLFssw@public.gmane.org
Subject: Re: [PATCH] mk: fix dependencies when modifying config
Date: Wed, 26 Mar 2014 23:14:41 +0100 [thread overview]
Message-ID: <1944547.AP9M4ybhh5@xps13> (raw)
In-Reply-To: <5332FB65.3000708-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2014-03-26 17:08, Olivier MATZ:
> On 03/19/2014 12:36 PM, Thomas Monjalon wrote:
> > If .config file is changed and .depdirs was built before,
> > it must be updated.
> > It is now done silently (-s) in checkconfig rule.
> > Now .depdirs is not redone if .config is older.
> >
> > It has been tested by enabling PMD_PCAP after a default build.
> > KVARGS dependency should appear in .depdirs.
> >
> > Signed-off-by: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
>
> Looks good to me. Just see one comment below.
>
> > ..PHONY: depdirs
>
> It seems there is a typo (..PHONY instead of .PHONY), it could
> be a good occasion to fix it. In my opinion, it can be done in the
> same patch as this typo does not create a real issue.
Applied with the typo fix.
Thanks for the review
--
Thomas
prev parent reply other threads:[~2014-03-26 22:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-19 11:36 [PATCH] mk: fix dependencies when modifying config Thomas Monjalon
[not found] ` <1395228982-24858-1-git-send-email-thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2014-03-26 16:08 ` Olivier MATZ
[not found] ` <5332FB65.3000708-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2014-03-26 22:14 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1944547.AP9M4ybhh5@xps13 \
--to=thomas.monjalon-pdr9zngts4eavxtiumwx3w@public.gmane.org \
--cc=dev-VfR2kkLFssw@public.gmane.org \
--cc=olivier.matz-pdR9zngts4EAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.