From: Thomas Monjalon <thomas@monjalon.net>
To: David Marchand <david.marchand@redhat.com>
Cc: Bruce Richardson <bruce.richardson@intel.com>,
dev@dpdk.org, omer.yamac@ceng.metu.edu.tr,
Ferruh Yigit <ferruh.yigit@amd.com>
Subject: Re: [PATCH] devtools: catch empty symbol maps
Date: Tue, 15 Nov 2022 18:20:44 +0100 [thread overview]
Message-ID: <1944772.8hb0ThOEGa@thomas> (raw)
In-Reply-To: <4f0df49a-c78c-b84c-fa4c-ed96f8d900c7@amd.com>
14/11/2022 16:10, Ferruh Yigit:
> On 11/14/2022 2:31 PM, Bruce Richardson wrote:
> > On Mon, Nov 14, 2022 at 03:16:51PM +0100, David Marchand wrote:
> >> version.map are now optional for drivers if no symbol is exported.
> >> Having no symbol exported from a library does not make sense.
> >>
> >> Catch all empty maps and warn about them.
> >>
> >> Example:
> >> $ ./devtools/check-symbol-maps.sh
> >> Found empty maps:
> >> drivers/crypto/uadk/version.map
> >> drivers/net/gve/version.map
> >> drivers/net/idpf/version.map
> >>
> >> Signed-off-by: David Marchand <david.marchand@redhat.com>
> >
> > Acked-by: Bruce Richardson <bruce.richardson@intel.com>
>
> +1 to have automated checks,
> Tested-by: Ferruh Yigit <ferruh.yigit@amd.com>
Applied, thanks.
prev parent reply other threads:[~2022-11-15 17:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-14 14:16 [PATCH] devtools: catch empty symbol maps David Marchand
2022-11-14 14:31 ` Bruce Richardson
2022-11-14 15:10 ` Ferruh Yigit
2022-11-15 17:20 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1944772.8hb0ThOEGa@thomas \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=omer.yamac@ceng.metu.edu.tr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.