From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1OB8yb-0005Sc-3S
	for qemu-devel@nongnu.org; Sun, 09 May 2010 12:03:33 -0400
Received: from [140.186.70.92] (port=57570 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OB8yP-0005C2-Ka
	for qemu-devel@nongnu.org; Sun, 09 May 2010 12:03:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <herbszt@gmx.de>) id 1OB8xy-0002BH-0p
	for qemu-devel@nongnu.org; Sun, 09 May 2010 12:02:55 -0400
Received: from mail.gmx.net ([213.165.64.20]:57002)
	by eggs.gnu.org with smtp (Exim 4.69)
	(envelope-from <herbszt@gmx.de>) id 1OB8xx-0002Ar-Iu
	for qemu-devel@nongnu.org; Sun, 09 May 2010 12:02:53 -0400
Message-ID: <1945C1D2D39F43239CFD537CA66DA5F8@FSCPC>
From: "Sebastian Herbszt" <herbszt@gmx.de>
Date: Sun, 9 May 2010 18:01:50 +0200
MIME-Version: 1.0
Content-Type: text/plain; format=flowed; charset="utf-8"; reply-type=original
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] AHCI support integration
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: =?utf-8?B?5LmU5bSH?= <qiaochong@loongson.cn>, Joerg Roedel <joro@8bytes.org>, Sebastian Herbszt <herbszt@gmx.de>, Alexander Graf <agraf@suse.de>, Elek Roland <elek.roland@gmail.com>

The ICH6 AHCI implementation submitted by Chong is an all-in-one attempt (ahci.c).
It includes all needed parts of the ICH6, AHCI, SATA and ATA specification.
The code in hw/ide/* on the other hand is split (or could be split) into smaller parts like
port based and bus master access, IDE and ATA core.
I think it might be reasonable to split ahci.c into ICH6, AHCI and SATA parts and strip the
limited ATA support and reuse it from the ide core.
This would give us something like the following:

hw/ide/piix.c (PIIX3 and PIIX4)
hw/ide/pci.c and core.c (IDE, BM)
hw/ata-core.c (ATA)
hw/sata/ich6.c (ICH6)
hw/sata-core.c (SATA)
hw/ahci-core.c (AHCI)

Should this be a goal or am i over-engineering here?

Sebastian