From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH] adv7511: Added mode_fixup function. Date: Fri, 29 Jan 2016 19:48:35 +0200 Message-ID: <1948106.WC7MId72vp@avalon> References: <1454063627-12219-1-git-send-email-palminha@synopsys.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from galahad.ideasonboard.com (galahad.ideasonboard.com [185.26.127.97]) by gabe.freedesktop.org (Postfix) with ESMTPS id F0CBF6E9E9 for ; Fri, 29 Jan 2016 09:48:18 -0800 (PST) In-Reply-To: <1454063627-12219-1-git-send-email-palminha@synopsys.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Carlos Palminha Cc: Laurent Pinchart , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org SGkgQ2FybG9zLAoKVGhhbmsgeW91IGZvciB0aGUgcGF0Y2guCgpPbiBGcmlkYXkgMjkgSmFudWFy eSAyMDE2IDEwOjMzOjQ3IENhcmxvcyBQYWxtaW5oYSB3cm90ZToKPiBUaGUgbW9kZV9maXh1cCBp cyBuZWNlc3Nhcnkgd2hlbiB1c2luZyBpdCBpbiBhIERSTSBGQiBkcml2ZXIgcGlwZWxpbmUuCgpJ bnN0ZWFkIG9mIGltcGxlbWVudGluZyBzdHVicyBpbiBlbmNvZGVyIGRyaXZlcnMsIHdvdWxkbid0 IGl0IGJlIGJldHRlciB0byAKbWFrZSBtb2RlX2ZpeHVwIG9wdGlvbmFsID8KCj4gU2lnbmVkLW9m Zi1ieTogQ2FybG9zIFBhbG1pbmhhIDxwYWxtaW5oYUBzeW5vcHN5cy5jb20+Cj4gLS0tCj4gIGRy aXZlcnMvZ3B1L2RybS9pMmMvYWR2NzUxMS5jIHwgOCArKysrKysrKwo+ICAxIGZpbGUgY2hhbmdl ZCwgOCBpbnNlcnRpb25zKCspCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pMmMv YWR2NzUxMS5jIGIvZHJpdmVycy9ncHUvZHJtL2kyYy9hZHY3NTExLmMKPiBpbmRleCA1MzNkMWUz Li45MDA4MmQyIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pMmMvYWR2NzUxMS5jCj4g KysrIGIvZHJpdmVycy9ncHUvZHJtL2kyYy9hZHY3NTExLmMKPiBAQCAtNjQ4LDYgKzY0OCwxMyBA QCBhZHY3NTExX2VuY29kZXJfZGV0ZWN0KHN0cnVjdCBkcm1fZW5jb2RlciAqZW5jb2RlciwKPiAg CXJldHVybiBzdGF0dXM7Cj4gIH0KPiAKPiArc3RhdGljIGJvb2wgYWR2NzUxMV9lbmNvZGVyX21v ZGVfZml4dXAoc3RydWN0IGRybV9lbmNvZGVyICplbmNvZGVyLAo+ICsJCQkJCWNvbnN0IHN0cnVj dCBkcm1fZGlzcGxheV9tb2RlICptb2RlLAo+ICsJCQkJCXN0cnVjdCBkcm1fZGlzcGxheV9tb2Rl ICphZGp1c3RlZF9tb2RlKQo+ICt7Cj4gKwlyZXR1cm4gdHJ1ZTsKPiArfQo+ICsKPiAgc3RhdGlj IGludCBhZHY3NTExX2VuY29kZXJfbW9kZV92YWxpZChzdHJ1Y3QgZHJtX2VuY29kZXIgKmVuY29k ZXIsCj4gIAkJCQkgICAgICBzdHJ1Y3QgZHJtX2Rpc3BsYXlfbW9kZSAqbW9kZSkKPiAgewo+IEBA IC03NTQsNiArNzYxLDcgQEAgc3RhdGljIHZvaWQgYWR2NzUxMV9lbmNvZGVyX21vZGVfc2V0KHN0 cnVjdCBkcm1fZW5jb2Rlcgo+ICplbmNvZGVyLAo+IAo+ICBzdGF0aWMgY29uc3Qgc3RydWN0IGRy bV9lbmNvZGVyX3NsYXZlX2Z1bmNzIGFkdjc1MTFfZW5jb2Rlcl9mdW5jcyA9IHsKPiAgCS5kcG1z ID0gYWR2NzUxMV9lbmNvZGVyX2RwbXMsCj4gKwkubW9kZV9maXh1cCA9IGFkdjc1MTFfZW5jb2Rl cl9tb2RlX2ZpeHVwLAo+ICAJLm1vZGVfdmFsaWQgPSBhZHY3NTExX2VuY29kZXJfbW9kZV92YWxp ZCwKPiAgCS5tb2RlX3NldCA9IGFkdjc1MTFfZW5jb2Rlcl9tb2RlX3NldCwKPiAgCS5kZXRlY3Qg PSBhZHY3NTExX2VuY29kZXJfZGV0ZWN0LAoKLS0gClJlZ2FyZHMsCgpMYXVyZW50IFBpbmNoYXJ0 CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2 ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xp c3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932732AbcA2RsU (ORCPT ); Fri, 29 Jan 2016 12:48:20 -0500 Received: from galahad.ideasonboard.com ([185.26.127.97]:38761 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932544AbcA2RsT (ORCPT ); Fri, 29 Jan 2016 12:48:19 -0500 From: Laurent Pinchart To: Carlos Palminha Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, David Airlie , Laurent Pinchart Subject: Re: [PATCH] adv7511: Added mode_fixup function. Date: Fri, 29 Jan 2016 19:48:35 +0200 Message-ID: <1948106.WC7MId72vp@avalon> User-Agent: KMail/4.14.8 (Linux/4.1.12-gentoo; KDE/4.14.8; x86_64; ; ) In-Reply-To: <1454063627-12219-1-git-send-email-palminha@synopsys.com> References: <1454063627-12219-1-git-send-email-palminha@synopsys.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Carlos, Thank you for the patch. On Friday 29 January 2016 10:33:47 Carlos Palminha wrote: > The mode_fixup is necessary when using it in a DRM FB driver pipeline. Instead of implementing stubs in encoder drivers, wouldn't it be better to make mode_fixup optional ? > Signed-off-by: Carlos Palminha > --- > drivers/gpu/drm/i2c/adv7511.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/gpu/drm/i2c/adv7511.c b/drivers/gpu/drm/i2c/adv7511.c > index 533d1e3..90082d2 100644 > --- a/drivers/gpu/drm/i2c/adv7511.c > +++ b/drivers/gpu/drm/i2c/adv7511.c > @@ -648,6 +648,13 @@ adv7511_encoder_detect(struct drm_encoder *encoder, > return status; > } > > +static bool adv7511_encoder_mode_fixup(struct drm_encoder *encoder, > + const struct drm_display_mode *mode, > + struct drm_display_mode *adjusted_mode) > +{ > + return true; > +} > + > static int adv7511_encoder_mode_valid(struct drm_encoder *encoder, > struct drm_display_mode *mode) > { > @@ -754,6 +761,7 @@ static void adv7511_encoder_mode_set(struct drm_encoder > *encoder, > > static const struct drm_encoder_slave_funcs adv7511_encoder_funcs = { > .dpms = adv7511_encoder_dpms, > + .mode_fixup = adv7511_encoder_mode_fixup, > .mode_valid = adv7511_encoder_mode_valid, > .mode_set = adv7511_encoder_mode_set, > .detect = adv7511_encoder_detect, -- Regards, Laurent Pinchart