From: Zirong Lang <zlang@redhat.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 1/2] lib/tst_mkfs: new tst_mkfs_sized function for create appointed size fs
Date: Wed, 9 Mar 2016 10:09:49 -0500 (EST) [thread overview]
Message-ID: <1949942365.27778261.1457536189138.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20160309130921.GB28171@rei.lan>
----- 原始邮件 -----
> 发件人: "Cyril Hrubis" <chrubis@suse.cz>
> 收件人: "Zorro Lang" <zlang@redhat.com>
> 抄送: ltp@lists.linux.it
> 发送时间: 星期三, 2016年 3 月 09日 下午 9:09:21
> 主题: Re: [PATCH 1/2] lib/tst_mkfs: new tst_mkfs_sized function for create appointed size fs
>
> Hi!
> > +void tst_mkfs_sized(void (cleanup_fn)(void), const char *dev,
> > + const char *fs_type, const char *const fs_opts[],
> > + const char *fssize, const char *blocksize);
> > +
> > +#define tst_mkfs(cleanup_fn, dev, fs_type, fs_opts) \
> > + tst_mkfs_sized(cleanup_fn, dev, fs_type, fs_opts, NULL, NULL)
>
> Also make this static inline function instead. We only use such macros
> for SAFE_MACROS() where we have to pass correct __FILE__ and __LINE__,
> which is very special occasion.
OK, I will change it to inline function.
>
> --
> Cyril Hrubis
> chrubis@suse.cz
>
prev parent reply other threads:[~2016-03-09 15:09 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-08 13:35 [LTP] [PATCH 1/2] lib/tst_mkfs: new tst_mkfs_sized function for create appointed size fs Zorro Lang
2016-03-08 13:35 ` [LTP] [PATCH 2/2] mmap16: fix ETIMEDOUT error if test device is too large Zorro Lang
2016-03-09 2:22 ` Eryu Guan
2016-03-09 3:12 ` Zirong Lang
2016-03-09 13:07 ` [LTP] [PATCH 1/2] lib/tst_mkfs: new tst_mkfs_sized function for create appointed size fs Cyril Hrubis
2016-03-09 15:31 ` Zirong Lang
2016-03-09 15:52 ` Cyril Hrubis
2016-03-09 16:05 ` Zirong Lang
2016-03-09 16:09 ` Cyril Hrubis
2016-03-09 16:30 ` Zirong Lang
2016-03-09 17:43 ` Cyril Hrubis
2016-03-10 1:45 ` Zirong Lang
2016-03-10 10:04 ` Cyril Hrubis
2016-03-10 12:00 ` Zirong Lang
2016-03-10 12:19 ` Cyril Hrubis
2016-03-10 13:30 ` Zirong Lang
2016-03-10 14:06 ` Cyril Hrubis
2016-03-10 16:24 ` Zirong Lang
2016-03-14 17:15 ` Cyril Hrubis
2016-03-09 16:01 ` Zirong Lang
2016-03-09 13:09 ` Cyril Hrubis
2016-03-09 15:09 ` Zirong Lang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1949942365.27778261.1457536189138.JavaMail.zimbra@redhat.com \
--to=zlang@redhat.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.