Re: [dpdk-dev] [PATCH v5 3/3] devtools: check flow API doc tables

[Thomas Monjalon <thomas@monjalon.net>]

13/05/2021 20:40, Ferruh Yigit:
> On 4/7/2021 11:33 PM, Thomas Monjalon wrote:
> > +changed_files()
> > +{
> > +	[ -n "$files" ] ||
> > +		files=$(git diff-tree --name-only -r $trusted_commit..)
> > +	echo "$files"
> > +}
> > +
> > +has_code_change() # <pattern>
> > +{
> > +	test -n "$(git log --format='%h' -S"$1" $trusted_commit..)"
> > +}
> > +
> > +has_file_change() # <pattern>
> > +{
> > +	changed_files | grep -q "$1"
> > +}
> > +
> > +changed_net_drivers()
> > +{
> > +	net_paths='drivers/net/|doc/guides/nics/features/'
> > +	[ -n "$drivers" ] ||
> > +		drivers=$(changed_files |
> > +			sed -rn "s,^($net_paths)([^./]*).*,\2,p")
> > +	echo "$drivers"
> > +}
> 
> I will not reviewed in details yet, but first observation,
> when 'trusted_commit' argument is used, the drivers list has many duplicated
> entries which makes the output redundant and makes script take too much time.
> Getting only unique list may help on it.

Yes good catch, thanks.