From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E0A31C021B8 for ; Wed, 26 Feb 2025 08:32:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date :Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=RTPCL3bJ22/BfZ0DYy+zPJ2HcQNthlLl55iYHSsXgf4=; b=SDiTvFFl8OUuSFuuaeQL0mW4nr zYhugebDYmKsO6WpkuZvO1TrtpJhqo0bGe5byizGBeVzGKmM2Ad9iNBR2HKbxtXnzWTLZC+70JB/7 gq9vpYaOKgqloqmuTL1bWYeA8uZHyIX527/9ODfoqtVEmEPlxdczJyulqdWo04mHtLBltmM1hTn7I IAm1itusaz/ReJID1RAA1rFlzp5XS8GD36mBw6iDMX8dpX4VGyoKfHr9DuPj7+hVTiSZI7pM5gz49 K9Mwvhq3UDqY2BxPwYMAerLtEUamz9D/7xxJGdqW+plVFQlDe7zaNdLGEms8RLVVMqHenQDHX1C6k lDlwi5Qg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tnCpn-00000002tc2-26h5; Wed, 26 Feb 2025 08:32:03 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tnCRn-00000002oe0-08Pq; Wed, 26 Feb 2025 08:07:16 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sntech.de; s=gloria202408; h=Content-Type:Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=RTPCL3bJ22/BfZ0DYy+zPJ2HcQNthlLl55iYHSsXgf4=; b=fRP53DWuVGxiOES0oTWTWO40pa aQbMHORaTsVwKaFQnsDdyAO6FV5Pu5jiMrr6lVAfy2+Z3UOfhrHVSanu++BR3slgsrN7yXB4UkSWy X2auVT4MHLTC5wBWSrl9he6ntyojDcxdf/j9XUfVnAXBuihGbjgOTsNK39VVVp07tVTJExZ7NYjrk jj6pmdh4BqDYXpMB/3bfEcArywK1xToNDaMt+RHVjZzC8v2fKkg34zKyGcre3Rxcj+8j2Puc865/O g618ljGYIwK4KWm9Rw9H5xVn1imt6Nmhl6t80evJ8MwT+4pUXVPvr8yIIh8k6Wmcm93lFBLtGi0KK KjqbuwqA==; Received: from i53875b47.versanet.de ([83.135.91.71] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tnCRk-0004zD-A4; Wed, 26 Feb 2025 09:07:12 +0100 From: Heiko =?UTF-8?B?U3TDvGJuZXI=?= To: Quentin Schulz Cc: linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Heiko Stuebner , Chen-Yu Tsai Subject: Re: [PATCH v2] arm64: dts: rockchip: add usb typec host support to rk3588-jaguar Date: Wed, 26 Feb 2025 09:07:11 +0100 Message-ID: <1952248.GKX7oQKdZx@diego> In-Reply-To: <18716872.sWSEgdgrri@diego> References: <20250218211044.2256762-1-heiko@sntech.de> <18716872.sWSEgdgrri@diego> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250226_000715_090876_EDB9D16E X-CRM114-Status: GOOD ( 30.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am Freitag, 21. Februar 2025, 22:53:20 MEZ schrieb Heiko St=C3=BCbner: > Am Freitag, 21. Februar 2025, 17:43:08 MEZ schrieb Quentin Schulz: > > Hi Heiko, > >=20 > > On 2/18/25 10:10 PM, Heiko Stuebner wrote: > > > From: Heiko Stuebner > > >=20 > > > Jaguar has two type-c ports connected to fusb302 controllers that can > > > work both in host and device mode and can also run in display-port > > > altmode. > > >=20 > > > While these ports can work in dual-role data mode, they do not support > > > powering the device itself as power-sink. This causes issues because > > > the current infrastructure does not cope well with dual-role data > > > without dual-role power. > > >=20 > > > So add the necessary nodes for the type-c controllers as well > > > as enable the relevant core usb nodes, but limit the mode to host-mode > > > for now until we figure out device mode. > > >=20 > > > Signed-off-by: Heiko Stuebner > >=20 > > While the USB functionality does work for both ports, and the=20 > > orientation is properly reported, it seems like there may be some issue= =20 > > with how the PHY or controller interacts with that info because I do no= t=20 > > get USB3 speeds when the device is inserted in reverse orientation,=20 > > while I do when it's in normal orientation. >=20 > I've tested both ports and saw the issue too. > Interestingly on the usbdp-phy side, orientation detection seems correct > and also the sbu pins are set accordingly. >=20 >=20 > > I assume that's the case for the Rock 5 ITX and Orange Pi 5+ as well an= d=20 > > probably has nothing to do with the DT? > >=20 > > Should we go still go on with trying to merge this patch knowing that? = I=20 > > mean USB2 is still better than no USB at all :) > >=20 > > +Cc Chen-Yu, owner of an Orange Pi 5+, who may be able to confirm the=20 > > issue is widespread. =46or reference, after digging around I found out that the usbdp-phy does n= ot handle the orientation correctly but relies on specific behaviour of the dw= c3 controller (suspending between unplug and plugin). usbdp-phy series fixing that is in https://lore.kernel.org/linux-rockchip/20250225184519.3586926-1-heiko@sntec= h.de/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C08DBC021BC for ; Wed, 26 Feb 2025 08:21:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7Yjdk7UXBOP4b+INiqC18oE2U+q1SxtdrZ4rHs0zevs=; b=AaeYaFLBShJIRG q5VjRnFOgHb5mxbHYq//Ej8qb7M9/u/D0PUpIO7kR/gjFR1/iZdwaVGXE3lAFKAz+bAF/w44IU6eg kRn9d1YzA5UD56Dmf4DWG+Sh4xXTNHUpVwhpSYWMU4TgCLD4pdOE5++i3w/D3SefUVj09E8qCyWdz UiuPrIOBJUbxCkmfTRm53LJeshiQu/aW4r5+ru3xMg+B5ij3bglbnegi2Tath3zzg+FDgvVnBv3YV 35tuwuW2Eafx/tXgDpaabDHBbSBdo5O+UQu2WVxUq2feMLU7UO2kj8R+nYHE8stpjILOtER0eLwzU 4VPvuP8a+wJT/wWMJuiA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tnCfN-00000002rMX-0SkE; Wed, 26 Feb 2025 08:21:17 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tnCRn-00000002oe0-08Pq; Wed, 26 Feb 2025 08:07:16 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sntech.de; s=gloria202408; h=Content-Type:Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=RTPCL3bJ22/BfZ0DYy+zPJ2HcQNthlLl55iYHSsXgf4=; b=fRP53DWuVGxiOES0oTWTWO40pa aQbMHORaTsVwKaFQnsDdyAO6FV5Pu5jiMrr6lVAfy2+Z3UOfhrHVSanu++BR3slgsrN7yXB4UkSWy X2auVT4MHLTC5wBWSrl9he6ntyojDcxdf/j9XUfVnAXBuihGbjgOTsNK39VVVp07tVTJExZ7NYjrk jj6pmdh4BqDYXpMB/3bfEcArywK1xToNDaMt+RHVjZzC8v2fKkg34zKyGcre3Rxcj+8j2Puc865/O g618ljGYIwK4KWm9Rw9H5xVn1imt6Nmhl6t80evJ8MwT+4pUXVPvr8yIIh8k6Wmcm93lFBLtGi0KK KjqbuwqA==; Received: from i53875b47.versanet.de ([83.135.91.71] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tnCRk-0004zD-A4; Wed, 26 Feb 2025 09:07:12 +0100 From: Heiko =?UTF-8?B?U3TDvGJuZXI=?= To: Quentin Schulz Cc: linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Heiko Stuebner , Chen-Yu Tsai Subject: Re: [PATCH v2] arm64: dts: rockchip: add usb typec host support to rk3588-jaguar Date: Wed, 26 Feb 2025 09:07:11 +0100 Message-ID: <1952248.GKX7oQKdZx@diego> In-Reply-To: <18716872.sWSEgdgrri@diego> References: <20250218211044.2256762-1-heiko@sntech.de> <18716872.sWSEgdgrri@diego> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250226_000715_090876_EDB9D16E X-CRM114-Status: GOOD ( 30.21 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org QW0gRnJlaXRhZywgMjEuIEZlYnJ1YXIgMjAyNSwgMjI6NTM6MjAgTUVaIHNjaHJpZWIgSGVpa28g U3TDvGJuZXI6Cj4gQW0gRnJlaXRhZywgMjEuIEZlYnJ1YXIgMjAyNSwgMTc6NDM6MDggTUVaIHNj aHJpZWIgUXVlbnRpbiBTY2h1bHo6Cj4gPiBIaSBIZWlrbywKPiA+IAo+ID4gT24gMi8xOC8yNSAx MDoxMCBQTSwgSGVpa28gU3R1ZWJuZXIgd3JvdGU6Cj4gPiA+IEZyb206IEhlaWtvIFN0dWVibmVy IDxoZWlrby5zdHVlYm5lckBjaGVycnkuZGU+Cj4gPiA+IAo+ID4gPiBKYWd1YXIgaGFzIHR3byB0 eXBlLWMgcG9ydHMgY29ubmVjdGVkIHRvIGZ1c2IzMDIgY29udHJvbGxlcnMgdGhhdCBjYW4KPiA+ ID4gd29yayBib3RoIGluIGhvc3QgYW5kIGRldmljZSBtb2RlIGFuZCBjYW4gYWxzbyBydW4gaW4g ZGlzcGxheS1wb3J0Cj4gPiA+IGFsdG1vZGUuCj4gPiA+IAo+ID4gPiBXaGlsZSB0aGVzZSBwb3J0 cyBjYW4gd29yayBpbiBkdWFsLXJvbGUgZGF0YSBtb2RlLCB0aGV5IGRvIG5vdCBzdXBwb3J0Cj4g PiA+IHBvd2VyaW5nIHRoZSBkZXZpY2UgaXRzZWxmIGFzIHBvd2VyLXNpbmsuIFRoaXMgY2F1c2Vz IGlzc3VlcyBiZWNhdXNlCj4gPiA+IHRoZSBjdXJyZW50IGluZnJhc3RydWN0dXJlIGRvZXMgbm90 IGNvcGUgd2VsbCB3aXRoIGR1YWwtcm9sZSBkYXRhCj4gPiA+IHdpdGhvdXQgZHVhbC1yb2xlIHBv d2VyLgo+ID4gPiAKPiA+ID4gU28gYWRkIHRoZSBuZWNlc3Nhcnkgbm9kZXMgZm9yIHRoZSB0eXBl LWMgY29udHJvbGxlcnMgYXMgd2VsbAo+ID4gPiBhcyBlbmFibGUgdGhlIHJlbGV2YW50IGNvcmUg dXNiIG5vZGVzLCBidXQgbGltaXQgdGhlIG1vZGUgdG8gaG9zdC1tb2RlCj4gPiA+IGZvciBub3cg dW50aWwgd2UgZmlndXJlIG91dCBkZXZpY2UgbW9kZS4KPiA+ID4gCj4gPiA+IFNpZ25lZC1vZmYt Ynk6IEhlaWtvIFN0dWVibmVyIDxoZWlrby5zdHVlYm5lckBjaGVycnkuZGU+Cj4gPiAKPiA+IFdo aWxlIHRoZSBVU0IgZnVuY3Rpb25hbGl0eSBkb2VzIHdvcmsgZm9yIGJvdGggcG9ydHMsIGFuZCB0 aGUgCj4gPiBvcmllbnRhdGlvbiBpcyBwcm9wZXJseSByZXBvcnRlZCwgaXQgc2VlbXMgbGlrZSB0 aGVyZSBtYXkgYmUgc29tZSBpc3N1ZSAKPiA+IHdpdGggaG93IHRoZSBQSFkgb3IgY29udHJvbGxl ciBpbnRlcmFjdHMgd2l0aCB0aGF0IGluZm8gYmVjYXVzZSBJIGRvIG5vdCAKPiA+IGdldCBVU0Iz IHNwZWVkcyB3aGVuIHRoZSBkZXZpY2UgaXMgaW5zZXJ0ZWQgaW4gcmV2ZXJzZSBvcmllbnRhdGlv biwgCj4gPiB3aGlsZSBJIGRvIHdoZW4gaXQncyBpbiBub3JtYWwgb3JpZW50YXRpb24uCj4gCj4g SSd2ZSB0ZXN0ZWQgYm90aCBwb3J0cyBhbmQgc2F3IHRoZSBpc3N1ZSB0b28uCj4gSW50ZXJlc3Rp bmdseSBvbiB0aGUgdXNiZHAtcGh5IHNpZGUsIG9yaWVudGF0aW9uIGRldGVjdGlvbiBzZWVtcyBj b3JyZWN0Cj4gYW5kIGFsc28gdGhlIHNidSBwaW5zIGFyZSBzZXQgYWNjb3JkaW5nbHkuCj4gCj4g Cj4gPiBJIGFzc3VtZSB0aGF0J3MgdGhlIGNhc2UgZm9yIHRoZSBSb2NrIDUgSVRYIGFuZCBPcmFu Z2UgUGkgNSsgYXMgd2VsbCBhbmQgCj4gPiBwcm9iYWJseSBoYXMgbm90aGluZyB0byBkbyB3aXRo IHRoZSBEVD8KPiA+IAo+ID4gU2hvdWxkIHdlIGdvIHN0aWxsIGdvIG9uIHdpdGggdHJ5aW5nIHRv IG1lcmdlIHRoaXMgcGF0Y2gga25vd2luZyB0aGF0PyBJIAo+ID4gbWVhbiBVU0IyIGlzIHN0aWxs IGJldHRlciB0aGFuIG5vIFVTQiBhdCBhbGwgOikKPiA+IAo+ID4gK0NjIENoZW4tWXUsIG93bmVy IG9mIGFuIE9yYW5nZSBQaSA1Kywgd2hvIG1heSBiZSBhYmxlIHRvIGNvbmZpcm0gdGhlIAo+ID4g aXNzdWUgaXMgd2lkZXNwcmVhZC4KCkZvciByZWZlcmVuY2UsIGFmdGVyIGRpZ2dpbmcgYXJvdW5k IEkgZm91bmQgb3V0IHRoYXQgdGhlIHVzYmRwLXBoeSBkb2VzIG5vdApoYW5kbGUgdGhlIG9yaWVu dGF0aW9uIGNvcnJlY3RseSBidXQgcmVsaWVzIG9uIHNwZWNpZmljIGJlaGF2aW91ciBvZiB0aGUg ZHdjMwpjb250cm9sbGVyIChzdXNwZW5kaW5nIGJldHdlZW4gdW5wbHVnIGFuZCBwbHVnaW4pLgoK dXNiZHAtcGh5IHNlcmllcyBmaXhpbmcgdGhhdCBpcyBpbgpodHRwczovL2xvcmUua2VybmVsLm9y Zy9saW51eC1yb2NrY2hpcC8yMDI1MDIyNTE4NDUxOS4zNTg2OTI2LTEtaGVpa29Ac250ZWNoLmRl LwoKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpMaW51 eC1yb2NrY2hpcCBtYWlsaW5nIGxpc3QKTGludXgtcm9ja2NoaXBAbGlzdHMuaW5mcmFkZWFkLm9y ZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LXJvY2tj aGlwCg==