From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Jackson Subject: Re: [PATCH] libxl: fix linking error Date: Wed, 21 Jul 2010 16:56:43 +0100 Message-ID: <19527.6331.710821.617543@mariner.uk.xensource.com> References: <201007201824.30154.Christoph.Egger@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <201007201824.30154.Christoph.Egger@amd.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Christoph Egger Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org Christoph Egger writes ("[Xen-devel] [PATCH] libxl: fix linking error"): > Attached patch fixes linking error when creating the xl binary. > The xl binary compiles in xl_cmdimpl.c which calls code from > libxl_paths.c and libxl_bootloader.c. ... > -$(CLIENTS): xl.o xl_cmdimpl.o xl_cmdtable.o libxlutil.so libxenlight.so > +$(CLIENTS): xl.o xl_cmdimpl.o xl_cmdtable.o libxl_paths.o libxl_bootloader.o libxlutil.so libxenlight.so This can't possibly be right. Files called "libxl_*.o" are parts of libxl and should be in libxenlight.so. I see, however, that Stefano has already applied it. Ian.