All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: Bruce Richardson
	<bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: dev-VfR2kkLFssw@public.gmane.org
Subject: Re: [BUG] ixgbe vector cannot compile without bulk alloc
Date: Mon, 01 Dec 2014 09:22:28 -0800 (PST)	[thread overview]
Message-ID: <1953153.vMxMoL6Atb@xps13> (raw)
In-Reply-To: <20141201171854.GH4856@bricha3-MOBL3>

2014-12-01 17:18, Bruce Richardson:
> On Mon, Dec 01, 2014 at 06:10:18PM +0100, Thomas Monjalon wrote:
> > These 2 configuration options are incompatible:
> > 	CONFIG_RTE_LIBRTE_IXGBE_RX_ALLOW_BULK_ALLOC=n
> > 	CONFIG_RTE_IXGBE_INC_VECTOR=y
> > Building this config gives this error:
> > 	lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c:69:24:
> > 	error: ‘struct igb_rx_queue’ has no member named ‘fake_mbuf’
> > 
> > I'd like a confirmation that it will be always incompatible.
> > Thanks
> 
> Hi Thomas,
> 
> I don't think these options should always be incompatible, though as you point
> out you do need to turn on bulk alloc support in order to use the vector PMD.
> Why do you ask? There are no immediate plans to remove the dependency on our end.

I think the compilation shouldn't fail without a proper message.
In order to distinguish a real compilation error from an incompatibility,
we should add a warning in the makefile.
Ideally, the build system should handle dependencies. But waiting this ideal
time, a warning would be graceful.

-- 
Thomas

  reply	other threads:[~2014-12-01 17:22 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-01 17:10 [BUG] ixgbe vector cannot compile without bulk alloc Thomas Monjalon
2014-12-01 17:18 ` Bruce Richardson
2014-12-01 17:22   ` Thomas Monjalon [this message]
2015-01-29 22:18     ` Thomas Monjalon
2015-01-29 23:27       ` Bruce Richardson
2015-01-29 23:31         ` [PATCH] ixgbe: forbid building vpmd without Rx " Thomas Monjalon
     [not found]           ` <1422574319-9428-1-git-send-email-thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2015-02-20 11:03             ` Thomas Monjalon
2015-01-29 23:39         ` [BUG] ixgbe vector cannot compile without " Liang, Cunming
     [not found]           ` <D0158A423229094DA7ABF71CF2FA0DA3118C1680-E2R4CRU6q/6iAffOGbnezLfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-01-30  3:38             ` Bruce Richardson
2015-01-30 19:21               ` Liang, Cunming

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1953153.vMxMoL6Atb@xps13 \
    --to=thomas.monjalon-pdr9zngts4eavxtiumwx3w@public.gmane.org \
    --cc=bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=dev-VfR2kkLFssw@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.