All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Wunderlich <sw@simonwunderlich.de>
To: Paolo Abeni <pabeni@redhat.com>, Eric Dumazet <edumazet@google.com>
Cc: Sven Eckelmann <sven@narfation.org>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	netdev@vger.kernel.org
Subject: Re: [PATCH net v3] batman-adv: Fix double-hold of meshif when getting enabled
Date: Thu, 10 Apr 2025 14:42:34 +0200	[thread overview]
Message-ID: <1957790.GKX7oQKdZx@prime> (raw)
In-Reply-To: <CANn89iJgmwTfQBi7aaMY40_JnA47MjzCF2+Md89dgyE9Cgt9DA@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1293 bytes --]

On Thursday, April 10, 2025 1:20:21 PM CEST Eric Dumazet wrote:
> On Thu, Apr 10, 2025 at 12:13 PM Paolo Abeni <pabeni@redhat.com> wrote:
> > On 4/9/25 9:35 AM, Sven Eckelmann wrote:
> > > It was originally meant to replace the dev_hold with netdev_hold. But
> > > this
> > > was missed in this place and thus there was an imbalance when trying to
> > > remove the interfaces.
> > > 
> > > Fixes: 00b35530811f ("batman-adv: adopt netdev_hold() / netdev_put()")
> > > Signed-off-by: Sven Eckelmann <sven@narfation.org>
> > 
> > You must wait at least 24h before reposting, see:
> > 
> > https://elixir.bootlin.com/linux/v6.14-rc6/source/Documentation/process/ma
> > intainer-netdev.rst#L15
> > 
> > Also this is somewhat strange: the same patch come from 2 different
> > persons (sometimes with garbled SoBs), and we usually receive PR for
> > batman patches.
> > 
> > @Svev, @Simon: could you please double check you are on the same page
> > and clarify the intent here?
> 
> Also I do not see credits given to syzbot  team ?
> 
> https://lkml.org/lkml/2025/4/8/1988

Sorry, there were some mistakes on our side. We'll take a deep breath and 
repost this on another day, most likely as part of a usual pull request. Sorry 
for the noise.

Cheers,
       Simon

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2025-04-10 12:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-09  7:35 [PATCH net v3] batman-adv: Fix double-hold of meshif when getting enabled Sven Eckelmann
2025-04-10 10:13 ` Paolo Abeni
2025-04-10 11:20   ` Eric Dumazet
2025-04-10 12:42     ` Simon Wunderlich [this message]
2025-04-10 13:08   ` Sven Eckelmann
2025-04-10 13:31     ` Eric Dumazet
2025-04-10 18:57       ` Sven Eckelmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1957790.GKX7oQKdZx@prime \
    --to=sw@simonwunderlich.de \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=sven@narfation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.