From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 255D4CA0FFE for ; Tue, 2 Sep 2025 07:41:44 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id CFB7141396; Tue, 2 Sep 2025 07:41:43 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id Vvxo9LrETB6z; Tue, 2 Sep 2025 07:41:43 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 56B1A41398 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1756798903; bh=IeU3paiQ9HhrqVYRKq8jOEDqZ9NfHngwUbp9m30YdWo=; h=Date:To:Cc:References:From:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=u7QY4l0QDdwhw3QFuE5B/jjrhvlJhzslxWQTnIdzrmgySEYLAmOL3BnC4XqJeWEPZ K3wZADnBpbW43M5NNQ59xqkDdDx3kJ8Gh6OhEE/hB3YG5Tj4n22td0LanruoutbhE4 E1vVhQ3cyUymNmxAUch4KtYNubCjPUFa9MWABUU+urnkyEc0IonMTPSVlHd0BUvjAX usZ6yo6rRHIZZ0K7+MTBD5a+QtBtYfmb6LBE8dgmPpWp9V9G46MeLwboP+OWl3i47L EN3LnpXEp+uMrYRmACBVXU0Bdy+n+1dsrCVTQakDym10SjebuidT2UZkgUkWG5MODb UuxxmamVpo8lA== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp4.osuosl.org (Postfix) with ESMTP id 56B1A41398; Tue, 2 Sep 2025 07:41:43 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138]) by lists1.osuosl.org (Postfix) with ESMTP id 24C1DD2 for ; Tue, 2 Sep 2025 07:41:42 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 0A9488451C for ; Tue, 2 Sep 2025 07:41:42 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id C31nm6N5nXCO for ; Tue, 2 Sep 2025 07:41:41 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=95.215.58.178; helo=out-178.mta1.migadu.com; envelope-from=vadim.fedorenko@linux.dev; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp1.osuosl.org 418E28451B DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 418E28451B Received: from out-178.mta1.migadu.com (out-178.mta1.migadu.com [95.215.58.178]) by smtp1.osuosl.org (Postfix) with ESMTPS id 418E28451B for ; Tue, 2 Sep 2025 07:41:40 +0000 (UTC) Message-ID: <195a39b6-e4e6-48b0-bb47-3c86d8be20fa@linux.dev> Date: Tue, 2 Sep 2025 08:41:23 +0100 MIME-Version: 1.0 To: Brahmajit Das Cc: andrew+netdev@lunn.ch, anthony.l.nguyen@intel.com, davem@davemloft.net, intel-wired-lan@lists.osuosl.org, kuba@kernel.org, netdev@vger.kernel.org, przemyslaw.kitszel@intel.com References: <20250902072422.603237-1-listout@listout.xyz> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Vadim Fedorenko In-Reply-To: <20250902072422.603237-1-listout@listout.xyz> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1756798897; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IeU3paiQ9HhrqVYRKq8jOEDqZ9NfHngwUbp9m30YdWo=; b=q3UoKuHI6ukCKweGSo4WX/fL2NwxsGF2knvkeWskJUIHacuCDJL7uQQJOXeRMc4BHADlMz tSTTwdJ3r0MkXZSzgcpihM1CVtctB4FKpu83Jxg0yqxZ76owrtESOeeGdeB4sbeXMeRkCp 99jB3zagFkLf9Gl+8CevvDdXfA724iU= X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dmarc=pass (p=none dis=none) header.from=linux.dev X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dkim=pass (1024-bit key, unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=q3UoKuHI Subject: Re: [Intel-wired-lan] [PATCH v2] net: intel: fm10k: Fix parameter idx set but not used X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On 02/09/2025 08:24, Brahmajit Das wrote: > Variable idx is set in the loop, but is never used resulting in dead > code. Building with GCC 16, which enables > -Werror=unused-but-set-parameter= by default results in build error. > This patch removes the idx parameter, since all the callers of the > fm10k_unbind_hw_stats_q as 0 as idx anyways. > > Suggested-by: Vadim Fedorenko > Signed-off-by: Brahmajit Das Reviewed-by: Vadim Fedorenko From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-181.mta1.migadu.com (out-181.mta1.migadu.com [95.215.58.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CD64A2E2F05 for ; Tue, 2 Sep 2025 07:41:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756798902; cv=none; b=TZCNO4RDglvWob2iAvsakQ1sSkN5TtETRldfNYeItEdLyEF5/CVt9LhZYpCs8BbiugOx9wdqTiMMPyLTuQrRZBSDoOeUAk+bjzA4EGDeZFoR//zkWgHH63dhmKWLOTYK5t67GBUOCQNw4RrC0t1nnoNI+rVbynQch/tImUSxNaM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756798902; c=relaxed/simple; bh=QIK209W21FlyFntgm+zs6uQT9kcebOLcZlrG1QTxl1w=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=qrX/skfSsyvvedX49J7tsPbiGb6rh7V+0eQwZ9uN2OSYTbkeKHC9eK6KXB9VNcFIc31Ch1yIBq1omHeTFc6aSbSPktS4rF3VHC8wYlGniI1wqzCKfmH3e8VuIiBEEoreYzsSnhxp2+8qoXi36QK25lYPyjj4voU5P8t25GOvfHY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=q3UoKuHI; arc=none smtp.client-ip=95.215.58.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="q3UoKuHI" Message-ID: <195a39b6-e4e6-48b0-bb47-3c86d8be20fa@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1756798897; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IeU3paiQ9HhrqVYRKq8jOEDqZ9NfHngwUbp9m30YdWo=; b=q3UoKuHI6ukCKweGSo4WX/fL2NwxsGF2knvkeWskJUIHacuCDJL7uQQJOXeRMc4BHADlMz tSTTwdJ3r0MkXZSzgcpihM1CVtctB4FKpu83Jxg0yqxZ76owrtESOeeGdeB4sbeXMeRkCp 99jB3zagFkLf9Gl+8CevvDdXfA724iU= Date: Tue, 2 Sep 2025 08:41:23 +0100 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH v2] net: intel: fm10k: Fix parameter idx set but not used To: Brahmajit Das Cc: andrew+netdev@lunn.ch, anthony.l.nguyen@intel.com, davem@davemloft.net, intel-wired-lan@lists.osuosl.org, kuba@kernel.org, netdev@vger.kernel.org, przemyslaw.kitszel@intel.com References: <20250902072422.603237-1-listout@listout.xyz> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Vadim Fedorenko In-Reply-To: <20250902072422.603237-1-listout@listout.xyz> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 02/09/2025 08:24, Brahmajit Das wrote: > Variable idx is set in the loop, but is never used resulting in dead > code. Building with GCC 16, which enables > -Werror=unused-but-set-parameter= by default results in build error. > This patch removes the idx parameter, since all the callers of the > fm10k_unbind_hw_stats_q as 0 as idx anyways. > > Suggested-by: Vadim Fedorenko > Signed-off-by: Brahmajit Das Reviewed-by: Vadim Fedorenko