From: Paul Eggleton <paul.eggleton@linux.intel.com>
To: Kevin Strasser <kevin.strasser@linux.intel.com>
Cc: yocto@yoctoproject.org
Subject: Re: [meta-baryon][PATCH] ffmpeg: ensure libjpeg dependency is included
Date: Fri, 13 Jul 2012 14:57:24 +0100 [thread overview]
Message-ID: <1961969.6JloXzyBcB@helios> (raw)
In-Reply-To: <1342132831-4596-1-git-send-email-kevin.strasser@linux.intel.com>
Hi Kevin,
On Thursday 12 July 2012 15:40:31 Kevin Strasser wrote:
> Signed-off-by: Kevin Strasser <kevin.strasser@linux.intel.com>
> ---
> recipes-core/base-files/base-files_3.0.14.bbappend | 2 +-
> .../ffmpeg/ffmpegthumbnailer_2.0.7.bb | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/recipes-core/base-files/base-files_3.0.14.bbappend b/recipes-core/base-files/base-files_3.0.14.bbappend
> index 593a37c..33217fb 100644
> --- a/recipes-core/base-files/base-files_3.0.14.bbappend
> +++ b/recipes-core/base-files/base-files_3.0.14.bbappend
> @@ -1,4 +1,4 @@
> # Set a hostname
> hostname_baryon = "baryon"
>
> -PRINC = "2"
> +PRINC = "3"
> diff --git a/recipes-multimedia/ffmpeg/ffmpegthumbnailer_2.0.7.bb b/recipes-multimedia/ffmpeg/ffmpegthumbnailer_2.0.7.bb
> index ec6d625..4f70ab8 100644
> --- a/recipes-multimedia/ffmpeg/ffmpegthumbnailer_2.0.7.bb
> +++ b/recipes-multimedia/ffmpeg/ffmpegthumbnailer_2.0.7.bb
> @@ -6,7 +6,7 @@ LICENSE = "GPLv2"
> LIC_FILES_CHKSUM = "file://COPYING;md5=393a5ca445f6965873eca0259a17f833"
> SRC_URI = "http://ffmpegthumbnailer.googlecode.com/files/${PN}-${PV}.tar.gz"
>
> -DEPENDS = "ffmpeg libpng"
> +DEPENDS = "ffmpeg jpeg libpng"
>
> SRC_URI[md5sum] = "2b5726894792ef484793dce9568a065a"
> SRC_URI[sha256sum] = "a71155339d17201a13fc3ebb649b0d00c7ab2d5a8880da071c8157a69c6f612b"
>
A couple of things:
1) You've bumped PRINC on base-files, I think what you need to do instead is
bump PR on ffmpegthumbnailer.
2) The subject line (shortlog) should refer to ffmpegthumbnailer rather than
ffmpeg.
Cheers,
Paul
--
Paul Eggleton
Intel Open Source Technology Centre
prev parent reply other threads:[~2012-07-13 13:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-12 22:40 [meta-baryon][PATCH] ffmpeg: ensure libjpeg dependency is included Kevin Strasser
2012-07-13 13:57 ` Paul Eggleton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1961969.6JloXzyBcB@helios \
--to=paul.eggleton@linux.intel.com \
--cc=kevin.strasser@linux.intel.com \
--cc=yocto@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.