All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Stancek <jstancek@redhat.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v3 5/5] kernel/syscalls: add new test with 'open() + O_TMPFILE'
Date: Tue, 26 Apr 2016 05:47:34 -0400 (EDT)	[thread overview]
Message-ID: <1962140078.296306.1461664054799.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20160425150735.GE20158@rei.lan>





----- Original Message -----
> From: "Cyril Hrubis" <chrubis@suse.cz>
> To: "Alexey Kodanev" <alexey.kodanev@oracle.com>
> Cc: "Jan Stancek" <jstancek@redhat.com>, "vasily isaenko" <vasily.isaenko@oracle.com>, ltp@lists.linux.it
> Sent: Monday, 25 April, 2016 5:07:35 PM
> Subject: Re: [LTP] [PATCH v3 5/5] kernel/syscalls: add new test with 'open() + O_TMPFILE'
> 
> Hi!
> > If the issue with mode... it can be because glibc doesn't process mode
> > argument unless O_CREAT is found. In our case we have O_TMPFILE instead.
> > 
> > Here is the link to bugzilla:
> > 
> > "open() and openat() ignore 'mode' with O_TMPFILE"
> > https://sourceware.org/bugzilla/show_bug.cgi?id=17523

Thanks. Jeff Bastian independently found this BZ as well. 
systemtap confirms, that mode remains 0, even when testcase is
passing non-zero values.

sys_openat ., dfd=0xffffffffffffff9c filename=0x40ac50 flags=0x404002 mode=0x0

> 
> What I see matches the the behavior in Comment 5.

I'm on aarch64, so that may explain why both fail for me.

After applying this patch:
  https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=65f6f938cd562a614a68e15d0581a34b177ec29d
both testcases passed.

Regards,
Jan

      reply	other threads:[~2016-04-26  9:47 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-29 12:05 [LTP] [PATCH v3 0/6] add open/openat + O_TMPFILE tests Alexey Kodanev
2016-01-29 12:05 ` [LTP] [PATCH v3 1/5] lib/tst_dir_is_empty: add a library function Alexey Kodanev
2016-01-29 12:05 ` [LTP] [PATCH v3 2/5] include/lapi/fcntl.h: add O_TMPFILE definition Alexey Kodanev
2016-01-29 12:05 ` [LTP] [PATCH v3 3/5] lib/safe_macros: add linkat() Alexey Kodanev
2016-01-29 12:05 ` [LTP] [PATCH v3 4/5] lib/safe_macros: add readlink() Alexey Kodanev
2016-01-29 12:05 ` [LTP] [PATCH v3 5/5] kernel/syscalls: add new test with 'open() + O_TMPFILE' Alexey Kodanev
2016-02-09 13:32   ` Cyril Hrubis
2016-02-10  8:36     ` Alexey Kodanev
2016-04-25 14:35   ` Jan Stancek
2016-04-25 15:04     ` Cyril Hrubis
2016-04-25 15:12     ` Alexey Kodanev
2016-04-25 15:07       ` Cyril Hrubis
2016-04-26  9:47         ` Jan Stancek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1962140078.296306.1461664054799.JavaMail.zimbra@redhat.com \
    --to=jstancek@redhat.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.