From: Paul Eggleton <paul.eggleton@linux.intel.com>
To: "Robert P. J. Day" <rpjday@crashcourse.ca>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: any current standard on avoiding use of both "_append" and "+="?
Date: Mon, 23 Jul 2012 10:15:03 +0100 [thread overview]
Message-ID: <1965034.biL4ROLyBP@helios> (raw)
In-Reply-To: <alpine.DEB.2.02.1207221512360.968@oneiric>
On Sunday 22 July 2012 15:12:51 Robert P. J. Day wrote:
> quick check shows this:
>
> recipes-graphics/xorg-lib/libxp_1.0.1.bb:CFLAGS_append += " -I
> ${S}/include/X11/XprintUtil -I ${S}/include/X11/extensions"
> recipes-sato/webkit/webkit-gtk_1.8.1.bb:EXTRA_OECONF_append_powerpc +=
> "--with-unicode-backend=glib"
> recipes-sato/webkit/webkit-gtk_1.8.1.bb:CPPFLAGS_append_powerpc +=
> "-I${STAGING_INCDIR}/pango-1.0 \
>
> was there going to be any effort to avoid combining "_append" with
> "+=" in recipe files, simply for the sake of clarity?
It's fine for these to be cleaned up as long as a leading space is added for
the second and third (since += will be doing this at the moment).
Cheers,
Paul
--
Paul Eggleton
Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-07-23 9:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-22 19:12 any current standard on avoiding use of both "_append" and "+="? Robert P. J. Day
2012-07-23 9:15 ` Paul Eggleton [this message]
2012-07-23 10:07 ` Robert P. J. Day
2012-07-23 10:12 ` Paul Eggleton
2012-07-23 10:15 ` Robert P. J. Day
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1965034.biL4ROLyBP@helios \
--to=paul.eggleton@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=rpjday@crashcourse.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.