All of lore.kernel.org
 help / color / mirror / Atom feed
From: Edip Hazuri <edip@medip.dev>
To: dmitry.torokhov@gmail.com, jikos@kernel.org
Cc: bentiss@kernel.org, linux-input@vger.kernel.org,
	linux-kernel@vger.kernel.org, Edip Hazuri <edip@medip.dev>
Subject: Re: [PATCH 1/2] Input: Add key event code for Fn + P
Date: Fri, 15 Aug 2025 17:49:55 +0300	[thread overview]
Message-ID: <1965589.tdWV9SEqCh@vilez> (raw)
In-Reply-To: <20250802212149.16707-2-edip@medip.dev>

On Sunday, August 3, 2025 12:21:50 AM GMT+03:00 edip@medip.dev wrote:
> From: Edip Hazuri <edip@medip.dev>
> 
> Newer Victus (and probably newer omen) laptops contains a "Fn + P"
> Shortcut. This is intended to use with Omen Gaming Hub, Which is
> changing the performance profile when this shortcut triggered. This
> shortcut is shown on performance control page, see [1]
> 
> Currently there is no key definition to handle this. So add a KEY_FN_P
> keycode define to be able to use this shortcut.
> 
> [1]: https://jpcdn.it/img/adadf6c927ffeb75afd8038f95db400a.png
> 
> Signed-off-by: Edip Hazuri <edip@medip.dev>
> ---
>  drivers/hid/hid-debug.c                | 2 +-
>  include/uapi/linux/input-event-codes.h | 1 +
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/hid/hid-debug.c b/drivers/hid/hid-debug.c
> index 4424c0512ba..2bcf7b24801 100644
> --- a/drivers/hid/hid-debug.c
> +++ b/drivers/hid/hid-debug.c
> @@ -3342,7 +3342,7 @@ static const char *keys[KEY_MAX + 1] = {
>  	[KEY_FN_1] = "Fn+1",			[KEY_FN_2] = 
"Fn+2",
>  	[KEY_FN_B] = "Fn+B",			[KEY_FN_D] = "Fn+D",
>  	[KEY_FN_E] = "Fn+E",			[KEY_FN_F] = 
"Fn+F",
> -	[KEY_FN_S] = "Fn+S",
> +	[KEY_FN_S] = "Fn+S",			[KEY_FN_P] = "Fn+P",
>  	[KEY_FN_F1] = "Fn+F1",			[KEY_FN_F2] = 
"Fn+F2",
>  	[KEY_FN_F3] = "Fn+F3",			[KEY_FN_F4] = 
"Fn+F4",
>  	[KEY_FN_F5] = "Fn+F5",			[KEY_FN_F6] = 
"Fn+F6",
> diff --git a/include/uapi/linux/input-event-codes.h
> b/include/uapi/linux/input-event-codes.h index 3b2524e4b66..2fc79b32425
> 100644
> --- a/include/uapi/linux/input-event-codes.h
> +++ b/include/uapi/linux/input-event-codes.h
> @@ -548,6 +548,7 @@
>  #define KEY_FN_S		0x1e3
>  #define KEY_FN_B		0x1e4
>  #define KEY_FN_RIGHT_SHIFT	0x1e5
> +#define KEY_FN_P		0x1e6
> 
>  #define KEY_BRL_DOT1		0x1f1
>  #define KEY_BRL_DOT2		0x1f2

Hello,

Please don't merge this. I made a v2 of this patch and this is no longer 
needed. 

Thanks!




      parent reply	other threads:[~2025-08-15 14:50 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-02 21:21 [PATCH 1/2] Input: Add key event code for Fn + P edip
2025-08-02 21:35 ` [PATCH 2/2] platform/x86: hp-wmi: Add support for Fn+P hotkey edip
2025-08-12 12:20   ` Ilpo Järvinen
2025-08-12 18:58     ` Edip Hazuri
2025-08-15 14:49 ` Edip Hazuri [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1965589.tdWV9SEqCh@vilez \
    --to=edip@medip.dev \
    --cc=20250802212149.16707-2-edip@medip.dev \
    --cc=bentiss@kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=jikos@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.