From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from dvalin.narfation.org (dvalin.narfation.org [213.160.73.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D93B5432304 for ; Sat, 1 Aug 2026 09:55:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.160.73.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785578151; cv=none; b=OabIxwkdopUpMWWgtXyix590F/hZFm7ugLLoWKIPZK5UuvJVPi7XRcWyUrWhgvaHg+od5YBRSD6Iqtop3LQ7U2AVeCw3BmhL4Jp+qv74jslqFI+ONRJqAudX6moVm5stfW/1DOl+VKBegquO8RQRghh+DE0ogXY0jKo0dZv2+ws= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785578151; c=relaxed/simple; bh=76QGQO285FjrhIAOXRV2zVHVHSMCXwU7a+2sA4fCyZU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=f2e/qMosIoXbRJMZhFmg2mz0PSvndPKssNj1DCC4B0UUvcHTHmqxrv6eEzqflSZJkEaSNBFDOu1PfA4Gp6i7btULEK2lLtJSENojF5Ki+dNZzMX9ZnCpIqKP2S4rhGSgpYMqSjVItdd8vPlo9bWua41LRnabWcsgxLWAGUzgJVA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=narfation.org; spf=pass smtp.mailfrom=narfation.org; dkim=pass (1024-bit key) header.d=narfation.org header.i=@narfation.org header.b=KBTUPCY1; arc=none smtp.client-ip=213.160.73.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=narfation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=narfation.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=narfation.org header.i=@narfation.org header.b="KBTUPCY1" Received: by dvalin.narfation.org (Postfix) id 4D5E620F35; Sat, 01 Aug 2026 09:55:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=narfation.org; s=20121; t=1785578142; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GMZ7u9TrJAkl++eWbVeHybzAtTqJM4wRotfi+f08UXo=; b=KBTUPCY1u1kOHe+TV0XPo//PAtHzD2/8yOR97A0iZ6mkcXYAKleXWfHnKxjXI7XDh2X2sZ 3esSVNdvqPs9+iy8Z7dkivYMzC4WFspw3sVBUktVE5/6KLjkuwVTQ2exmPHZhDpZekByRV qVsPIV5vMiYAafko/xDJn2pBB1U/cLE= From: Sven Eckelmann To: David Lee , Kyle Zeng Cc: Dominik 'Disconnect3d' Czarnota , b.a.t.m.a.n@lists.open-mesh.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] batman-adv: reject unrepresentable multicast TVLV offsets Date: Sat, 01 Aug 2026 11:55:39 +0200 Message-ID: <1966817.atdPhlSkOF@sven-desktop> In-Reply-To: <178551276852.62695.13954065440231922020.b4-review@b4> References: <20260731135222.566367-1-david.lee@trailofbits.com> <178551276852.62695.13954065440231922020.b4-review@b4> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart48293242.fMDQidcC6G"; micalg="pgp-sha512"; protocol="application/pgp-signature" --nextPart48293242.fMDQidcC6G Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8"; protected-headers="v1" From: Sven Eckelmann Date: Sat, 01 Aug 2026 11:55:39 +0200 Message-ID: <1966817.atdPhlSkOF@sven-desktop> In-Reply-To: <178551276852.62695.13954065440231922020.b4-review@b4> MIME-Version: 1.0 On Friday, 31 July 2026 17:46:08 CEST Sven Eckelmann wrote: > On Fri, 31 Jul 2026 13:52:22 +0000, David Lee wrote: > > batman-adv: reject unrepresentable multicast TVLV offsets > > Acked-by: Sven Eckelmann I am hereby withdrawing this. NACKed-by: Sven Eckelmann This needs a different implementation and a clean patch submission. Summary: 1. weird text + newlines in the tags section which shouldn't be there 2. author didn't sign off the patch 3. weird unrelated Signed-off-by without any understandable connection to patch 4. the checks should be in the API and not added in random places in callers of the API (which makes it hard to understand why the check is there). The users of the API should only handle the return values of the API functions. See commit d45cf1e7d718 ("ipv6: reject malicious packets in ipv6_gso_segment()") Regards, Sven --nextPart48293242.fMDQidcC6G Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQS81G/PswftH/OW8cVND3cr0xT1ywUCam3CmwAKCRBND3cr0xT1 y2mgAQDi/oHdlfdCkY06CmxenfGT17EvCOmDReQEwv8Eoa1fowEAzrJdzx7R4ZZB ZhJwKVbiHfzxT4cfFHnj4VqYsgjVKww= =RJcS -----END PGP SIGNATURE----- --nextPart48293242.fMDQidcC6G--