From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51166) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V6kVw-0008C5-48 for qemu-devel@nongnu.org; Tue, 06 Aug 2013 12:53:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V6kVq-0005j9-4Z for qemu-devel@nongnu.org; Tue, 06 Aug 2013 12:53:40 -0400 Received: from mx4-phx2.redhat.com ([209.132.183.25]:37537) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V6kVp-0005ir-T5 for qemu-devel@nongnu.org; Tue, 06 Aug 2013 12:53:34 -0400 Date: Tue, 6 Aug 2013 12:53:31 -0400 (EDT) From: Paolo Bonzini Message-ID: <1967239043.10289790.1375808011063.JavaMail.root@redhat.com> In-Reply-To: <1375785431-8390-1-git-send-email-lersek@redhat.com> References: <1375785431-8390-1-git-send-email-lersek@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 for-qmp-1.6 0/4] dump-guest-memory: correct the vmcores List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laszlo Ersek Cc: qemu-devel@nongnu.org, lcapitulino@redhat.com > v2->v3 [Paolo]: > - The memory API guarantees an increasing traversal. Drop the hash > tables and build the final list directly in the region_add callback, > merging any adjacent region only with the last element on the list. > (Patch #3.) I only looked at this change, it looks good. Thanks for this work! Paolo