From: Cong Wang <amwang@redhat.com>
To: Sridhar Samudrala <sri@us.ibm.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>
Subject: Re: [Patch net-next] vxlan: revert "vxlan: Bypass encapsulation if the destination is local"
Date: Fri, 12 Apr 2013 04:05:52 -0400 (EDT) [thread overview]
Message-ID: <1968568728.2717792.1365753952925.JavaMail.root@redhat.com> (raw)
In-Reply-To: <1365724799.3563.5.camel@sridhar.usor.ibm.com>
----- Original Message -----
>
> The following patch fixes the issue for me. can you try it out?
>
> diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
> index 9a64715..d6509de 100644
> --- a/drivers/net/vxlan.c
> +++ b/drivers/net/vxlan.c
> @@ -1013,7 +1013,7 @@ static netdev_tx_t vxlan_xmit_one(struct sk_buff *skb,
> struct net_device *dev,
> }
>
> /* Bypass encapsulation if the destination is local */
> - if (rt->rt_flags & RTCF_LOCAL) {
> + if (rt->dst.dev->flags & IFF_LOOPBACK) {
> struct vxlan_dev *dst_vxlan;
>
> ip_rt_put(rt);
>
It almost surely can fix the problem, but do you really just want to bypass
encap for loopback devcie? Not all local devices?
The title of your original commit "vxlan: Bypass encapsulation if the destination is local"
is confusing...
(Sorry for the delay, I am on vacation.)
next prev parent reply other threads:[~2013-04-12 8:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-09 9:57 [Patch net-next] vxlan: revert "vxlan: Bypass encapsulation if the destination is local" Cong Wang
2013-04-09 17:16 ` David Miller
2013-04-09 18:08 ` Sridhar Samudrala
2013-04-10 14:29 ` Sergei Shtylyov
2013-04-11 2:10 ` Cong Wang
2013-04-11 4:53 ` Sridhar Samudrala
2013-04-11 5:55 ` Cong Wang
2013-04-11 6:33 ` Sridhar Samudrala
2013-04-11 23:59 ` Sridhar Samudrala
2013-04-12 8:05 ` Cong Wang [this message]
2013-04-12 19:19 ` David Miller
2013-04-12 23:07 ` Sridhar Samudrala
2013-04-12 23:17 ` David Miller
2013-04-15 2:31 ` Cong Wang
2013-04-15 4:20 ` Sridhar Samudrala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1968568728.2717792.1365753952925.JavaMail.root@redhat.com \
--to=amwang@redhat.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=sri@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.