All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Arnon Warshavsky <arnon@qwilt.com>,
	"Burakov, Anatoly" <anatoly.burakov@intel.com>
Cc: Bruce Richardson <bruce.richardson@intel.com>, dev@dpdk.org
Subject: Re: [PATCH] eal: register rte_panic user callback
Date: Wed, 07 Mar 2018 16:06:22 +0100	[thread overview]
Message-ID: <1968690.y4bVNFghIW@xps> (raw)
In-Reply-To: <CAKy9EB1SaOVFDyDnszTJUGH9gON5-ULRf86kRcxRXT6WiPMWjg@mail.gmail.com>

07/03/2018 14:23, Arnon Warshavsky:
> >
> > Can we add a compile warning for adding new rte_panic's into code? It's a
> > nice tool while debugging, but it probably shouldn't be in any new
> > production code.

Yes could be nice to automatically detect it in drivers/ or lib/ directories.


> I thought about renaming the current function and calls to something like
> deprecated_rte_panic()
> , and keep the old API with __rte_deprecated.
> Is this kind of API break acceptable?

No, rte_panic can be used in applications.

  reply	other threads:[~2018-03-07 15:07 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-06 18:28 [PATCH] eal: register rte_panic user callback Arnon Warshavsky
2018-03-07  8:32 ` Thomas Monjalon
2018-03-07  8:57   ` Arnon Warshavsky
2018-03-07  9:05   ` Burakov, Anatoly
2018-03-07  9:59     ` Thomas Monjalon
2018-03-07 11:02       ` Arnon Warshavsky
2018-03-07 15:04         ` Thomas Monjalon
2018-03-07 16:26           ` Arnon Warshavsky
2018-03-07 11:29       ` Burakov, Anatoly
2018-03-07 13:23         ` Arnon Warshavsky
2018-03-07 15:06           ` Thomas Monjalon [this message]
2018-03-07 16:31             ` Arnon Warshavsky
2018-03-07 17:17               ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1968690.y4bVNFghIW@xps \
    --to=thomas@monjalon.net \
    --cc=anatoly.burakov@intel.com \
    --cc=arnon@qwilt.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.