From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2 2/2] mem: unmap unneeded space Date: Tue, 08 May 2018 22:20:15 +0200 Message-ID: <1968691.VWAu9saNLK@xps> References: <20180430125035.GB100464@bricha3-MOBL.ger.corp.intel.com> <4409303.1sNuYAC1ue@xps> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, Bruce Richardson To: Anatoly Burakov Return-path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 5DDB34CB3 for ; Tue, 8 May 2018 22:20:17 +0200 (CEST) In-Reply-To: <4409303.1sNuYAC1ue@xps> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 02/05/2018 23:00, Thomas Monjalon: > 30/04/2018 14:50, Bruce Richardson: > > On Mon, Apr 30, 2018 at 12:21:43PM +0100, Anatoly Burakov wrote: > > > When we ask to reserve virtual areas, we usually include > > > alignment in the mapping size, and that memory ends up > > > being wasted. Wasting a gigabyte of VA space while trying to > > > reserve one gigabyte is pretty expensive on 32-bit, so after > > > we're done mapping, unmap unneeded space. > > > > > > Signed-off-by: Anatoly Burakov > > > --- > > > > > > Notes: > > > v2: > > > - Split fix for size_t overflow into separate patch > > > - Improve readability of unmapping code > > > - Added comment explaining why unmapping is done > > > > > Acked-by: Bruce Richardson > > I am not confident pushing this change post-rc1. > Please can we have more validation tests with this patch? Any news about validation tests?