Re: [PATCH net-next v3 2/4] bonding: Extend arp_ip_target format to allow for a list of vlan tags.

[Jay Vosburgh <jv@jvosburgh.net>]

David Wilder <wilder@us.ibm.com> wrote:

>
>
>>        Here, and further down in bond_arp_ip_target_opt_parse(),
>>there's a lot of string handling that seems out place.  Why isn't the
>>string parsing done in user space (iproute, et al), and the tags passed
>>to the kernel in IFLA_BOND_ARP_IP_TARGET as an optional nested
>>attribute?
>
>>>+              }
>
>>        There is no expectation that sysfs should support new bonding
>>API elements; only netlink / iproute2 support matters.  If sysfs is the
>>reason to do the string parsing in the kernel, then I imagine this could
>>all move into userspace.
>>
>>     -J
>
>Module parameter support also requires string parsing in the kernel. Can that be dropped as well?

	Yes.  New bonding functionality need not be supported by sysfs
or module parameters.

	-J

---
	-Jay Vosburgh, jv@jvosburgh.net