Re: [Intel-xe] [PATCH 1/2] drm/xe: Add a new memory direcory under tile

[Riana Tauro <riana.tauro@intel.com>]

Hi Suja

Typo in subject
%s/direcory/directory

Thanks
Riana

On 11/24/2023 5:57 PM, Sujaritha Sundaresan wrote:
> Add a new memory directory under /device/tile<n> and move
> physical_vram_size attribute to the new directory.
> 
> New hierarchy:
> 
> /device/tile<n>/memory/physical_vram_size_bytes
> 
> Signed-off-by: Sujaritha Sundaresan <sujaritha.sundaresan@intel.com>
> ---
>   drivers/gpu/drm/xe/xe_tile_sysfs.c | 12 ++++++++++--
>   1 file changed, 10 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_tile_sysfs.c b/drivers/gpu/drm/xe/xe_tile_sysfs.c
> index 16376607c68f..f354c8b2bfc6 100644
> --- a/drivers/gpu/drm/xe/xe_tile_sysfs.c
> +++ b/drivers/gpu/drm/xe/xe_tile_sysfs.c
> @@ -24,7 +24,8 @@ static ssize_t
>   physical_vram_size_bytes_show(struct device *kdev, struct device_attribute *attr,
>   			      char *buf)
>   {
> -	struct xe_tile *tile = kobj_to_tile(&kdev->kobj);
> +	struct kobject *kobj = &kdev->kobj;
> +	struct xe_tile *tile = kobj_to_tile(kobj->parent);
>   
>   	return sysfs_emit(buf, "%llu\n", tile->mem.vram.actual_physical_size);
>   }
> @@ -46,6 +47,7 @@ void xe_tile_sysfs_init(struct xe_tile *tile)
>   	struct xe_device *xe = tile_to_xe(tile);
>   	struct device *dev = xe->drm.dev;
>   	struct kobj_tile *kt;
> +	struct kobject *kobj;
>   	int err;
>   
>   	kt = kzalloc(sizeof(*kt), GFP_KERNEL);
> @@ -64,8 +66,14 @@ void xe_tile_sysfs_init(struct xe_tile *tile)
>   
>   	tile->sysfs = &kt->base;
>   
> +	kobj = kobject_create_and_add("memory", tile->sysfs);
> +	if (!kobj) {
> +		drm_warn(&xe->drm, "%s failed, err: %d\n", __func__, -ENOMEM);
> +		return;
> +	}
> +
>   	if (IS_DGFX(xe) && xe->info.platform != XE_DG1 &&
> -	    sysfs_create_file(tile->sysfs, physical_memsize_attr))
> +	    sysfs_create_file(kobj, physical_memsize_attr)) >   		drm_warn(&xe->drm,
>   			 "Sysfs creation to read addr_range per tile failed\n");
>