From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hebbar Date: Tue, 30 Sep 2008 03:10:30 -0700 (PDT) Subject: [U-Boot] ARM Versatile port - possibly inefficient code? In-Reply-To: <40a670230809292340u249e1c87tccd6e32f6f711550@mail.gmail.com> References: <40a670230809292340u249e1c87tccd6e32f6f711550@mail.gmail.com> Message-ID: <19739341.post@talk.nabble.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi, >>Regardless of CFG_MAX_FLASH_BANKS value, the only first bank is >>configured. Was it done deliberately or it's logical flaw? I think >>is code could cloned on a multiple of other platforms. ARM Versatile has only one flash bank. What if a user has configured an incorrect number for flash banks. The driver should take care of this properly. Since CFG_MAX_FLASH_BANKS is in a different place & the flash.c is a different file, care is taken to see that an incorrect bank is not considered for initialization also, >>panic ("configured too many flash banks!\n"); this error message clearly explains the mistake the user did. Regards Gururaja -- View this message in context: http://www.nabble.com/-U-Boot--ARM-Versatile-port---possibly-inefficient-code--tp19736928p19739341.html Sent from the Uboot - Users mailing list archive at Nabble.com.