From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v1] eal: remove another use of register keyword Date: Mon, 15 Jan 2018 19:00:03 +0100 Message-ID: <1973968.l2YiJ7Szvs@xps> References: <20180115113323.24439-1-avi@scylladb.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Avi Kivity Return-path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 8B1F5A49F for ; Mon, 15 Jan 2018 19:00:35 +0100 (CET) In-Reply-To: <20180115113323.24439-1-avi@scylladb.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 15/01/2018 12:33, Avi Kivity: > The 'register' keyword does nothing, and has been removed in C++17. > > Remove it for compatibility, like commit 0d5f2ed12f9eb. Fixes: 0d5f2ed12f9e ("eal: remove use of register keyword") > Signed-off-by: Avi Kivity Applied, thanks. Note that "register" is used in some drivers too: git grep -l '\.*;' drivers/ | sed -r 's,([^/]*/[^/]*/[^/]*/).*,\1,' | sort -u drivers/bus/dpaa/ drivers/crypto/dpaa2_sec/ drivers/crypto/qat/ drivers/event/sw/ drivers/net/ark/ drivers/net/avp/ drivers/net/bnx2x/ drivers/net/bnxt/ drivers/net/e1000/ drivers/net/i40e/ drivers/net/ixgbe/ drivers/net/qede/ drivers/net/sfc/ drivers/net/vhost/