diff for duplicates of <1974170.pJAPFfvtjC@grover> diff --git a/a/1.txt b/N1/1.txt index 1072384..a9ee3bb 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -3,7 +3,7 @@ Daniel, I am not quite sure I understand what you want me to test? Do you want me to try it without: -> > + if (ret = 0) { +> > + if (ret == 0) { > > + ret = do_unregister_con_driver(&vga_con); Thanks @@ -49,15 +49,15 @@ On Monday 07 July 2014 10:48:26 Daniel Vetter wrote: > > > > console_lock(); > > - ret = do_take_over_console(&dummy_con, 0, MAX_NR_CONSOLES - 1, 1); -> > - if (ret = 0) { +> > - if (ret == 0) { > > - ret = do_unregister_con_driver(&vga_con); > > - > > - /* Ignore "already unregistered". */ -> > - if (ret = -ENODEV) +> > - if (ret == -ENODEV) > > - ret = 0; > > + if (con_is_bound(&vga_con)) { > > + ret = do_take_over_console(&dummy_con, 0, MAX_NR_CONSOLES - 1, 1); -> > + if (ret = 0) { +> > + if (ret == 0) { > > + ret = do_unregister_con_driver(&vga_con); > > Hm, we should only conditionalize the take_over_console - unregistering @@ -71,7 +71,7 @@ On Monday 07 July 2014 10:48:26 Daniel Vetter wrote: > Thanks, Daniel > > + > > + /* Ignore "already unregistered". */ -> > + if (ret = -ENODEV) +> > + if (ret == -ENODEV) > > + ret = 0; > > + } > > } diff --git a/a/content_digest b/N1/content_digest index af5e801..b411f27 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,8 +2,8 @@ "ref\020140630065955.GD7687@nuc-i3427.alporthouse.com\0" "ref\020140707084826.GH5821@phenom.ffwll.local\0" "From\0Ed Tomlinson <edt@aei.ca>\0" - "Subject\0Re: [Intel-gfx] [PATCH 5/5] drm/i915: Kick out vga console\0" - "Date\0Mon, 07 Jul 2014 10:45:49 +0000\0" + "Subject\0Re: [PATCH 5/5] drm/i915: Kick out vga console\0" + "Date\0Mon, 07 Jul 2014 06:45:49 -0400\0" "To\0Chris Wilson <chris@chris-wilson.co.uk>" Intel Graphics Development <intel-gfx@lists.freedesktop.org> DRI Development <dri-devel@lists.freedesktop.org> @@ -21,7 +21,7 @@ "I am not quite sure I understand what you want me to test?\n" "Do you want me to try it without:\n" "\n" - "> > + if (ret = 0) {\n" + "> > + if (ret == 0) {\n" "> > + ret = do_unregister_con_driver(&vga_con);\n" "\n" "Thanks\n" @@ -67,15 +67,15 @@ "> > \n" "> > console_lock();\n" "> > - ret = do_take_over_console(&dummy_con, 0, MAX_NR_CONSOLES - 1, 1);\n" - "> > - if (ret = 0) {\n" + "> > - if (ret == 0) {\n" "> > - ret = do_unregister_con_driver(&vga_con);\n" "> > -\n" "> > - /* Ignore \"already unregistered\". */\n" - "> > - if (ret = -ENODEV)\n" + "> > - if (ret == -ENODEV)\n" "> > - ret = 0;\n" "> > + if (con_is_bound(&vga_con)) {\n" "> > + ret = do_take_over_console(&dummy_con, 0, MAX_NR_CONSOLES - 1, 1);\n" - "> > + if (ret = 0) {\n" + "> > + if (ret == 0) {\n" "> > + ret = do_unregister_con_driver(&vga_con);\n" "> \n" "> Hm, we should only conditionalize the take_over_console - unregistering\n" @@ -89,7 +89,7 @@ "> Thanks, Daniel\n" "> > +\n" "> > + /* Ignore \"already unregistered\". */\n" - "> > + if (ret = -ENODEV)\n" + "> > + if (ret == -ENODEV)\n" "> > + ret = 0;\n" "> > + }\n" "> > }\n" @@ -100,4 +100,4 @@ "> \n" > -42714f4862a30e53ca9181455ed0644d4739087714d174ef50603b1f113ca44f +9f43e07d7ca759794f8f7233dc3946712849a0d8ea8453a47dd356b6ebf080b7
diff --git a/a/1.txt b/N2/1.txt index 1072384..a9ee3bb 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -3,7 +3,7 @@ Daniel, I am not quite sure I understand what you want me to test? Do you want me to try it without: -> > + if (ret = 0) { +> > + if (ret == 0) { > > + ret = do_unregister_con_driver(&vga_con); Thanks @@ -49,15 +49,15 @@ On Monday 07 July 2014 10:48:26 Daniel Vetter wrote: > > > > console_lock(); > > - ret = do_take_over_console(&dummy_con, 0, MAX_NR_CONSOLES - 1, 1); -> > - if (ret = 0) { +> > - if (ret == 0) { > > - ret = do_unregister_con_driver(&vga_con); > > - > > - /* Ignore "already unregistered". */ -> > - if (ret = -ENODEV) +> > - if (ret == -ENODEV) > > - ret = 0; > > + if (con_is_bound(&vga_con)) { > > + ret = do_take_over_console(&dummy_con, 0, MAX_NR_CONSOLES - 1, 1); -> > + if (ret = 0) { +> > + if (ret == 0) { > > + ret = do_unregister_con_driver(&vga_con); > > Hm, we should only conditionalize the take_over_console - unregistering @@ -71,7 +71,7 @@ On Monday 07 July 2014 10:48:26 Daniel Vetter wrote: > Thanks, Daniel > > + > > + /* Ignore "already unregistered". */ -> > + if (ret = -ENODEV) +> > + if (ret == -ENODEV) > > + ret = 0; > > + } > > } diff --git a/a/content_digest b/N2/content_digest index af5e801..df5aff4 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -3,7 +3,7 @@ "ref\020140707084826.GH5821@phenom.ffwll.local\0" "From\0Ed Tomlinson <edt@aei.ca>\0" "Subject\0Re: [Intel-gfx] [PATCH 5/5] drm/i915: Kick out vga console\0" - "Date\0Mon, 07 Jul 2014 10:45:49 +0000\0" + "Date\0Mon, 07 Jul 2014 06:45:49 -0400\0" "To\0Chris Wilson <chris@chris-wilson.co.uk>" Intel Graphics Development <intel-gfx@lists.freedesktop.org> DRI Development <dri-devel@lists.freedesktop.org> @@ -21,7 +21,7 @@ "I am not quite sure I understand what you want me to test?\n" "Do you want me to try it without:\n" "\n" - "> > + if (ret = 0) {\n" + "> > + if (ret == 0) {\n" "> > + ret = do_unregister_con_driver(&vga_con);\n" "\n" "Thanks\n" @@ -67,15 +67,15 @@ "> > \n" "> > console_lock();\n" "> > - ret = do_take_over_console(&dummy_con, 0, MAX_NR_CONSOLES - 1, 1);\n" - "> > - if (ret = 0) {\n" + "> > - if (ret == 0) {\n" "> > - ret = do_unregister_con_driver(&vga_con);\n" "> > -\n" "> > - /* Ignore \"already unregistered\". */\n" - "> > - if (ret = -ENODEV)\n" + "> > - if (ret == -ENODEV)\n" "> > - ret = 0;\n" "> > + if (con_is_bound(&vga_con)) {\n" "> > + ret = do_take_over_console(&dummy_con, 0, MAX_NR_CONSOLES - 1, 1);\n" - "> > + if (ret = 0) {\n" + "> > + if (ret == 0) {\n" "> > + ret = do_unregister_con_driver(&vga_con);\n" "> \n" "> Hm, we should only conditionalize the take_over_console - unregistering\n" @@ -89,7 +89,7 @@ "> Thanks, Daniel\n" "> > +\n" "> > + /* Ignore \"already unregistered\". */\n" - "> > + if (ret = -ENODEV)\n" + "> > + if (ret == -ENODEV)\n" "> > + ret = 0;\n" "> > + }\n" "> > }\n" @@ -100,4 +100,4 @@ "> \n" > -42714f4862a30e53ca9181455ed0644d4739087714d174ef50603b1f113ca44f +b0d4906c2511b5fc70dfeb6ef6c8b1980322ce47da0042bec64e15ad69be95eb
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.